Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never paginate fixed-positioned objects #33067

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Never paginate fixed-positioned objects #33067

wants to merge 1 commit into from

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Sep 3, 2024 •
edited by webkit-early-warning-system
Loading

45a96bd

Never paginate fixed-positioned objects
https://bugs.webkit.org/show_bug.cgi?id=279060
rdar://135189288

Reviewed by NOBODY (OOPS!).

Partial Merge: https://chromium.googlesource.com/chromium/src.git/+/344e69ca2b1f2e20346eeb1f6d3d7d9fad38fd82

This patch fixes an issue which is long standing, where the fixed-positioned
objects suppose to be repeated on every page but we don't do it but we
should not paginate them as well, which is addressed here.

We don't merge test case `fixedpos-in-transform-at-column-boundary.html`,
since it was converted to web platform tests by Blink in below commit [1]:

[1] https://chromium.googlesource.com/chromium/src/+/8ddecd73089b2c3f8d4092c699378caefe0d70bd

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination const):
* LayoutTests/printing/block-with-overflow-in-bottom-aligned-fixedpos-expected.html:
* LayoutTests/printing/block-with-overflow-in-bottom-aligned-fixedpos.html:
* LayoutTests/printing/flexbox-with-overflow-in-bottom-aligned-fixedpos-expected.html:
* LayoutTests/printing/flexbox-with-overflow-in-bottom-aligned-fixedpos.html:

45a96bd

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792
Never paginate fixed-positioned objects
45a96bd 
https://bugs.webkit.org/show_bug.cgi?id=279060
rdar://135189288

Reviewed by NOBODY (OOPS!).

Partial Merge: https://chromium.googlesource.com/chromium/src.git/+/344e69ca2b1f2e20346eeb1f6d3d7d9fad38fd82

This patch fixes an issue which is long standing, where the fixed-positioned
objects suppose to be repeated on every page but we don't do it but we
should not paginate them as well, which is is addressed here.

We don't merge test case `fixedpos-in-transform-at-column-boundary.html`,
since it was converted to web platform tests by Blink in below commit [1]:

[1] https://chromium.googlesource.com/chromium/src/+/8ddecd73089b2c3f8d4092c699378caefe0d70bd

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination const):
* LayoutTests/printing/block-with-overflow-in-bottom-aligned-fixedpos-expected.html:
* LayoutTests/printing/block-with-overflow-in-bottom-aligned-fixedpos.html:
* LayoutTests/printing/flexbox-with-overflow-in-bottom-aligned-fixedpos-expected.html:
* LayoutTests/printing/flexbox-with-overflow-in-bottom-aligned-fixedpos.html:
@Ahmad-S792 Ahmad-S792 self-assigned this Sep 3, 2024
@Ahmad-S792 Ahmad-S792 added the Printing For bugs in WebKit's printing support. label Sep 3, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2024 •
edited
Loading

EWS run on current version of this PR (hash 45a96bd)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 marked this pull request as draft September 3, 2024 14:49
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ahmad-S792 Ahmad-S792

Labels
merging-blocked Applied to prevent a change from being merged Printing For bugs in WebKit's printing support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ahmad-S792 @webkit-early-warning-system @webkit-ews-buildbot