Use HashMap::add in SVGTextLayoutAttributesBuilder #32358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=278292 rdar://134186468 Reviewed by NOBODY (OOPS!). Merge: https://chromium.googlesource.com/chromium/src.git/+/0f6c84977fee3a56a328e9baa1134b668a316569 Removes some redundancies and eliminates double-hashing. Do the update of default values last. * Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap): (WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):
|
EWS run on current version of this PR (hash 7afd778) |
Ahmad-S792
requested review from
smfr,
rwlbuis,
shallawa and
nikolaszimmermann
mdubet
reviewed
Aug 19, 2024
| } | ||
|
|
||
| updateCharacterData(i, lastRotation, it->value, lengthContext, xListPtr, yListPtr, dxListPtr, dyListPtr, rotateListPtr); | ||
| auto& data = m_characterDataMap.add((position.start + i + 1), SVGCharacterData()).iterator->value; |
There was a problem hiding this comment.
We should use HashMap::ensure() to avoid creating a useless SVGCharacterData() object when the key is already there.
| } | ||
|
|
||
| it->value.rotate = lastRotation; | ||
| auto& data = m_characterDataMap.add((position.start + i + 1), SVGCharacterData()).iterator->value; |
| // Fill character data map using child text positioning elements in top-down order. | ||
| unsigned size = m_textPositions.size(); | ||
| for (unsigned i = 0; i < size; ++i) | ||
| fillCharacterDataMap(m_textPositions[i]); | ||
|
|
||
| // Handle x/y default attributes. | ||
| auto& data = m_characterDataMap.add((1), SVGCharacterData()).iterator->value; |
rreno
reviewed
Aug 19, 2024
| SVGCharacterData data; | ||
| updateCharacterData(i, lastRotation, data, lengthContext, xListPtr, yListPtr, dxListPtr, dyListPtr, rotateListPtr); | ||
| m_characterDataMap.set(position.start + i + 1, data); | ||
| continue; |
There was a problem hiding this comment.
This logic has changed. You might want to check if isNewEntry when using HashMap::add and if so, continue to the next step of the loop.
| SVGCharacterData data; | ||
| data.rotate = lastRotation; | ||
| m_characterDataMap.set(position.start + i + 1, data); | ||
| continue; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7afd778
7afd778