[JSC] Move JSLock / JSUnlock from SPI to API #1439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=241504 Reviewed by NOBODY (OOPS!). Tadeu demonstrated that this JSLock and JSUnlock are useful for performance (via API bench). And it is also motivated by external clients too: "bun" from Jarred is adding literally the similar API in his own fork of JavaScriptCore to make it fast. We should move them from SPI to API to make it available to external clients. * PerformanceTests/APIBench/UpcomingAPI/RichardsMostlyC/RichardsMostlyC/richards.c: * PerformanceTests/APIBench/UpcomingAPI/RichardsMostlyObjC/RichardsMostlyObjC/WorkerTask.m: * PerformanceTests/APIBench/UpcomingAPI/RichardsMostlySwift/RichardsMostlySwift/BridgingHeader.h: * PerformanceTests/APIBench/UpcomingAPI/RichardsSomeC/RichardsSomeC/main.m: * PerformanceTests/APIBench/UpcomingAPI/RichardsSomeObjC/RichardsSomeObjC/main.m: * PerformanceTests/APIBench/UpcomingAPI/RichardsSomeSwift/RichardsSomeSwift/BridgingHeader.h: * Source/JavaScriptCore/API/JSContextRef.h: * Source/JavaScriptCore/API/JSLockRef.cpp: * Source/JavaScriptCore/API/JSLockRefPrivate.h: Removed. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
Constellation
added
JavaScriptCore
|
Since this will be API on Apple platforms, have we done the Apple-internal API review? Can we offer an ObjC API version too that automatically takes the lock, invokes a block, and then releases the lock? It's nice for our ObjC API to have feature parity, and also nice that it can do a little better than our C API in ease of use. |
webkit-early-warning-system
added
the
merging-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2a82116