[GTK][WPE] EventSenderProxy::rawKeyDown|Up are not implemented #10441
+38
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=251528 Reviewed by NOBODY (OOPS!). * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::EventSenderProxy::rawKeyDown): (WTR::EventSenderProxy::rawKeyUp): * Tools/WebKitTestRunner/libwpe/EventSenderProxyLibWPE.cpp: (WTR::EventSenderProxy::rawKeyDown): (WTR::EventSenderProxy::rawKeyUp):
carlosgcampos
requested review from
a team,
donny-dont and
zdobersek
as code owners
|
EWS run on current version of this PR (hash f3822f5)
|
carlosgcampos
added
the
Tools / Tests
shivamidow
reviewed
Mar 16, 2023
| @@ -333,12 +333,40 @@ void EventSenderProxy::keyDown(WKStringRef keyRef, WKEventModifiers wkModifiers, | |||
| #endif | |||
| } | |||
|
|
|||
| void EventSenderProxy::rawKeyDown(WKStringRef key, WKEventModifiers modifiers, unsigned keyLocation) | |||
| void EventSenderProxy::rawKeyDown(WKStringRef key, WKEventModifiers wkModifiers, unsigned keyLocation) | |||
There was a problem hiding this comment.
/* Unofficial Review */
This rawKeyDown and rawKeyUp below are almost duplicated except for two booleans. Can we put their code together into a single method with an isKeyPressed boolean argument as we do in EventSenderProxyGtk.cpp?
|
This also broke a lot of tests :( |
|
FWIW, in #13957 I reverted changes that had already landed to implement these methods for the GTK port. They broke several hundred tests, so when you land this please make sure to update the test results where appropriate. |
|
I've marked this as a draft since it looks like it's not ready yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f3822f5
f3822f5