render-manager: Don't paint when session is not active #2484
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when switching to another tty. A test is to run glxgears in a drm session with xwayland, then switch to another tty and run top. The wayfire cpu usage is 100+%. However with this patch, when the session is inactive, the cpu usage is negligible. One note is that patches were pushed to seatd recently which make the session->active state reliable. At the time of this writing, seatd does not have a release containing these patches, so for this to work reliably, seatd git master is recommended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when switching to another tty. A test is to run glxgears in a drm session with xwayland, then switch to another tty and run top. The wayfire cpu usage is 100+%. However with this patch, when the session is inactive, the cpu usage is negligible.
One note is that patches were pushed to seatd recently which make the session->active state reliable. At the time of this writing, seatd does not have a release containing these patches, so for this to work reliably, seatd git master is recommended.