-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wasi-nn] PyTorch AOTI #3724
base: master
Are you sure you want to change the base?
[Wasi-nn] PyTorch AOTI #3724
Conversation
Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR. plugins/wasi_nn/wasinn_torch.cppPotential issuesN/A Summary of changesN/A plugins/wasi_nn/wasinn_torch.hPotential issuesN/A Summary of changesN/A plugins/wasi_nn/wasinnenv.cppPotential issuesN/A Summary of changesN/A |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3724 +/- ##
=======================================
Coverage 78.70% 78.70%
=======================================
Files 272 272
Lines 36777 36777
Branches 6545 6539 -6
=======================================
Hits 28944 28944
- Misses 6346 6350 +4
+ Partials 1487 1483 -4 ☔ View full report in Codecov by Sentry. |
2d30161
to
204ca37
Compare
note: for manylinux_2_28_x86_64 , use |
I see, so there is still a compatible issue about the C++11 ABI in manylinux_2_28. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the [WASI-NN] Torch:
prefix for the logs.
f777d28
to
6e1fd9d
Compare
Signed-off-by: Sylveon <sylveon@secondstate.io>
Signed-off-by: Sylveon <sylveon@secondstate.io>
https://pytorch.org/docs/stable/torch.compiler_aot_inductor.html
Add a support to load the AOTInductor for PyTorch.
Note: use AOTInductor build by pip need the wasmedge with
_GLIBCXX_USE_CXX11_ABI=0