Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasi-nn] PyTorch AOTI #3724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Wasi-nn] PyTorch AOTI #3724

wants to merge 2 commits into from

Conversation

LFsWang
Copy link
Collaborator

@LFsWang LFsWang commented Sep 3, 2024

https://pytorch.org/docs/stable/torch.compiler_aot_inductor.html

Add a support to load the AOTInductor for PyTorch.

Note: use AOTInductor build by pip need the wasmedge with _GLIBCXX_USE_CXX11_ABI=0

  • Pump PyTorch from 1.8.0 to 2.4.1
  • Pump PyTorch from 2.4.1 to 2.5.1
  • Check old examples work
  • Merge this with origin PyTorch plugin

Copy link
Member

juntao commented Sep 3, 2024

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


plugins/wasi_nn/wasinn_torch.cpp

Potential issues

N/A

Summary of changes

N/A

plugins/wasi_nn/wasinn_torch.h

Potential issues

N/A

Summary of changes

N/A

plugins/wasi_nn/wasinnenv.cpp

Potential issues

N/A

Summary of changes

N/A

@github-actions github-actions bot added c-Plugin An issue related to WasmEdge Plugin WASI-NN https://github.com/WebAssembly/wasi-nn c-CMake An issue related to CMake mechanism or options labels Sep 3, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (31920fa) to head (8fc0664).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3724   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         272      272           
  Lines       36777    36777           
  Branches     6545     6539    -6     
=======================================
  Hits        28944    28944           
- Misses       6346     6350    +4     
+ Partials     1487     1483    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LFsWang LFsWang force-pushed the torchaoti branch 6 times, most recently from 2d30161 to 204ca37 Compare September 25, 2024 08:23
@github-actions github-actions bot removed the c-CMake An issue related to CMake mechanism or options label Sep 30, 2024
@LFsWang
Copy link
Collaborator Author

LFsWang commented Oct 8, 2024

note: for manylinux_2_28_x86_64 , use add_definitions(-D_GLIBCXX_USE_CXX11_ABI=0) and install pytorch with no c++11 abi will work

@hydai
Copy link
Member

hydai commented Oct 8, 2024

note: for manylinux_2_28_x86_64 , use add_definitions(-D_GLIBCXX_USE_CXX11_ABI=0) and install pytorch with no c++11 abi will work

I see, so there is still a compatible issue about the C++11 ABI in manylinux_2_28.

@LFsWang LFsWang changed the title [WIP][Wasi-nn] PyTorch AOTI [Wasi-nn] PyTorch AOTI Oct 12, 2024
@github-actions github-actions bot added the c-CI An issue related to CI label Oct 12, 2024
@LFsWang LFsWang marked this pull request as ready for review October 20, 2024 13:31
@LFsWang LFsWang requested review from dm4, hydai and 0yi0 as code owners October 20, 2024 13:31
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the [WASI-NN] Torch: prefix for the logs.

plugins/wasi_nn/wasinn_torch.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/wasinn_torch.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/wasinn_torch.cpp Outdated Show resolved Hide resolved
@LFsWang LFsWang force-pushed the torchaoti branch 2 times, most recently from f777d28 to 6e1fd9d Compare October 22, 2024 08:41
plugins/wasi_nn/wasinn_torch.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/wasinn_torch.cpp Outdated Show resolved Hide resolved
plugins/wasi_nn/wasinn_torch.h Outdated Show resolved Hide resolved
plugins/wasi_nn/wasinn_torch.h Outdated Show resolved Hide resolved
Signed-off-by: Sylveon <sylveon@secondstate.io>
Signed-off-by: Sylveon <sylveon@secondstate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-Plugin An issue related to WasmEdge Plugin WASI-NN https://github.com/WebAssembly/wasi-nn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants