render 0 in ct:value attribute for line graphs

Waicung · Feb 21, 2016 · 83d55b3 · 83d55b3
1 parent ff6bdf1
commit 83d55b3
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 1 deletion.
diff --git a/src/scripts/charts/line.js b/src/scripts/charts/line.js
@@ -206,7 +206,7 @@
             y2: pathElement.y
           }, options.classNames.point).attr({
             'value': [pathElement.data.value.x, pathElement.data.value.y].filter(function(v) {
-                return v;
+                return v || v === 0;
               }).join(','),
             'meta': pathElement.data.meta
           }, Chartist.xmlNs.uri);

diff --git a/test/spec/spec-line-chart.js b/test/spec/spec-line-chart.js
@@ -9,6 +9,52 @@ describe('Line chart tests', function () {
 
   });
 
+  describe('ct:value attribute', function () {
+    it('should contain x and y value for each datapoint', function (done) {
+      jasmine.getFixtures().set('<div class="ct-chart ct-golden-section"></div>');
+
+      var chart = new Chartist.Line('.ct-chart', {
+        series: [[
+          {x: 1, y: 2},
+          {x: 3, y: 4}
+        ]]
+      }, {
+        axisX: {
+          type: Chartist.FixedScaleAxis
+        }
+      });
+
+      chart.on('created', function () {
+        expect($('.ct-point').eq(0).attr('ct:value')).toEqual('1,2');
+        expect($('.ct-point').eq(1).attr('ct:value')).toEqual('3,4');
+        done();
+      });
+    });
+
+    it('should render values that are zero', function (done) {
+      jasmine.getFixtures().set('<div class="ct-chart ct-golden-section"></div>');
+
+      var chart = new Chartist.Line('.ct-chart', {
+        series: [[
+          {x: 0, y: 1},
+          {x: 1, y: 0},
+          {x: 0, y: 0}
+        ]]
+      }, {
+        axisX: {
+          type: Chartist.FixedScaleAxis
+        }
+      });
+
+      chart.on('created', function () {
+        expect($('.ct-point').eq(0).attr('ct:value')).toEqual('0,1');
+        expect($('.ct-point').eq(1).attr('ct:value')).toEqual('1,0');
+        expect($('.ct-point').eq(2).attr('ct:value')).toEqual('0,0');
+        done();
+      });
+    });
+  });
+
   describe('Meta data tests', function () {
     it('should render meta data correctly with mixed value array', function (done) {
       jasmine.getFixtures().set('<div class="ct-chart ct-golden-section"></div>');