[spec] Add B&A k-anonymity fields #1360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingxinwu
reviewed
Feb 3, 2025
| @@ -3485,6 +3492,57 @@ A <dfn>server auction response</dfn> is a [=struct=] that contains auction resul | |||
| :: A [=map=] whose [=map/keys=] are [=origins=] and whose [=map/values=] are [=lists=] of [=urls=]. | |||
| </dl> | |||
|
|
|||
| <dfn>server auction join candidates</dfn> is a [=struct=] with the following [=struct/items=]: | |||
There was a problem hiding this comment.
this is more like single "candidate", not "candidates", right? If so, can we call it "candidate" (as we did in code)
| :: A [=SHA-256=] hash of the [=k-anonymity key=] for the ad in the winning bid, | ||
| as calculated using [=compute the key hash of ad=]. | ||
| : <dfn>ad component render url hashes</dfn> | ||
| :: A [=list=] of [=SHA-256=] hashes for each of the ad components in the |
There was a problem hiding this comment.
Suggested change
| :: A [=list=] of [=SHA-256=] hashes for each of the ad components in the | |
| :: A [=list=] of [=SHA-256=] hashes of [=k-anonymity keys=] for each of the ad components in the |
| A <dfn>server auction ghost winner bid info</dfn> is a [=struct=] with the following [=struct/items=]: | ||
| <dl dfn-for="server auction ghost winner bid info"> | ||
| : <dfn>ad render url</dfn> | ||
| :: [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s [=generated bid/ad descriptor=]'s [=ad descriptor/url=] from the |
There was a problem hiding this comment.
nit
Suggested change
| :: [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s [=generated bid/ad descriptor=]'s [=ad descriptor/url=] from the | |
| :: A [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s [=generated bid/ad descriptor=]'s [=ad descriptor/url=] from the |
| :: [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s [=generated bid/ad descriptor=]'s [=ad descriptor/url=] from the | ||
| auction. | ||
| : <dfn>ad components</dfn> | ||
| :: A [=list=] of [=URLs=]. A list of the non-k-anonymous winning bid's |
There was a problem hiding this comment.
is "non-k-anonymous winning bid" the same as [=leading bid info/leading non-k-anon-enforced bid=]? If so, probably good to link to it as well, as what you did for render url above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the fields to the server response needed for Bidding and Auction Services k-anonymity support. A separate CL will be filed describing how these fields are interpreted by a browser.
This CL also removes some trailing whitespace that found its way into the spec.
Preview | Diff