Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paraview functions #490

Merged
merged 5 commits into from
Jan 19, 2021
Merged

paraview functions #490

merged 5 commits into from
Jan 19, 2021

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented Jan 6, 2021

This PR creates various write_paraview functions and removes the corresponding class methods to keep the classes clean.

@kmruehl kmruehl self-requested a review January 6, 2021 23:33
@kmruehl kmruehl added the Visualization Visualization and Paraview label Jan 6, 2021
@kmruehl
Copy link
Contributor

kmruehl commented Jan 16, 2021

@akeeste this cleans up the classes a lot. Thank you!

@kmruehl
Copy link
Contributor

kmruehl commented Jan 16, 2021

@akeeste I was able to run the Paraview applications cases, but I am unable to load the *.PVD file into Paraview, so I'm going to hold off on merging this PR until the issue is resolved.

@kmruehl kmruehl added the Bug bug in WEC-Sim source, high priority label Jan 18, 2021
@kmruehl
Copy link
Contributor

kmruehl commented Jan 18, 2021

This PR also resolves the bugs associated the #497 and #499. #497 is a hot fix but needs a better long-term solution.

@kmruehl
Copy link
Contributor

kmruehl commented Jan 18, 2021

@akeeste this works for me now. Thanks!

@kmruehl kmruehl merged commit 51605f2 into WEC-Sim:dev Jan 19, 2021
@kmruehl kmruehl deleted the viz_class branch January 19, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug bug in WEC-Sim source, high priority Visualization Visualization and Paraview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants