Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(openrtb): Extension refactor part1 - BidRequest Device Impression #115

Merged
merged 18 commits into from
May 9, 2022
Merged

refactor(openrtb): Extension refactor part1 - BidRequest Device Impression #115

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
354eee0
Remove unused x/lint mod and add go-cmp used for ut cases to show the…
Feb 8, 2022
4998743
Remove unused x/lint mod and add go-cmp used for ut cases to show the…
Feb 8, 2022
3afef9d
Update extension fields of bidrequest and its sub structs. Change the…
Feb 8, 2022
1393059
Fix lint issues.
Feb 8, 2022
8fe41ae
Regenerate easyjson files to keep the generate method for sub struct …
Feb 8, 2022
92996f3
Add lint mod back.
Feb 8, 2022
d0f88f0
Change extension of device to json.RawMessage.
Feb 10, 2022
2b595dd
Merge branch 'master' into wip-pbj-3419-raw-message-extension
HaibinZhang-Vungle Mar 25, 2022
8f9746d
Roll back all modifications for now, just handle ext in bidrequest.
Mar 25, 2022
3d5ae23
Roll back all modifications for now, just handle ext in bidrequest.
Mar 25, 2022
f288ecd
Merge branch 'wip-pbj-3419-raw-message-extension' of github.com:Vungl…
Mar 25, 2022
de271ae
Roll back all modifications for now, just handle ext in bidrequest.
Mar 25, 2022
721626e
Merge branch 'master' into wip-pbj-3419-raw-message-extension
HaibinZhang-Vungle Mar 28, 2022
fbb31fe
Update openrtb device extension to json RawMessage.
Apr 18, 2022
ffb11b6
Update openrtb impression extension to json RawMessage.
Apr 20, 2022
f1a808a
Merge pull request #120 from Vungle/wip-pbj-4146-refactor-openrtb-dev…
HaibinZhang-Vungle Apr 29, 2022
88aac8e
Update request_test.go
HaibinZhang-Vungle Apr 29, 2022
83429eb
Merge pull request #121 from Vungle/wip-pbj-4147-refactor-openrtb-imp…
HaibinZhang-Vungle Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions openrtb/bidrequest_easyjson.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions openrtb/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
package openrtb

import "github.com/Vungle/vungo/internal/util"
import (
"encoding/json"

"github.com/Vungle/vungo/internal/util"
)

// Device object provides information pertaining to the device through which the
// user is interacting.
Expand Down Expand Up @@ -267,7 +271,7 @@ type Device struct {
// object
// Description:
// Placeholder for exchange-specific extensions to OpenRTB.
Extension interface{} `json:"ext,omitempty"`
Extension json.RawMessage `json:"ext,omitempty"`
}

// Copy do deep copy of Device.
Expand Down Expand Up @@ -299,7 +303,7 @@ func (d *Device) Copy() *Device {
deviceCopy.SupportsJavaScript = &SupportsJavaScriptCopy
}
deviceCopy.GeoFetch = d.GeoFetch.Copy()
deviceCopy.Extension = util.DeepCopyCopiable(d.Extension)
deviceCopy.Extension = util.DeepCopyJSONRawMsg(d.Extension)

return &deviceCopy
}
18 changes: 4 additions & 14 deletions openrtb/device_easyjson.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.