Fix bug where Appraisal ran incompatible combination of Ruby and Rails (

#1333) Appraisal does not set the Ruby version, allowing developers to run our tests with incompatible combinations of Ruby and Rails. This change opts Rails 5.2 out of Ruby >=3.0. Closes #1326. Co-authored-by: Blake Williams <blakewilliams@github.com> Co-authored-by: Cameron Dutro <camertron@github.com> Co-authored-by: Blake Williams <blakewilliams@github.com> Co-authored-by: Cameron Dutro <camertron@github.com>
ViewComponent · Apr 14, 2022 · 1da3127 · 1da3127
1 parent 93a2de8
commit 1da3127
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Appraisals b/Appraisals
@@ -1,7 +1,11 @@
 # frozen_string_literal: true
 
-appraise "rails-5.2" do
-  gem "rails", "~> 5.2.0"
+if RUBY_VERSION < "3.0.0"
+  appraise "rails-5.2" do
+    gem "rails", "~> 5.2.0"
+  end
+else
+  puts "WARNING: Skipping Rails 5.2, as it is not compatible with Ruby >= 3.0.0"
 end
 
 appraise "rails-6.0" do

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -9,6 +9,10 @@ title: Changelog
 
 ## main
 
+* Skip Rails 5.2 in local test environment if using incompatible Ruby version.
+
+    *Cameron Dutro*, *Blake Williams*, *Joel Hawksley*
+
 * Improve landing page documentation.
 
     *Jason Swett*