Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MConvBNReLU by constructing PixelCNN with simple ConvBlocks + model edition #21

Open
Horgix opened this issue May 2, 2021 · 0 comments
Open

Replace MConvBNReLU by constructing PixelCNN with simple ConvBlocks + model edition #21

Horgix opened this issue May 2, 2021 · 0 comments

Comments

@Horgix
Copy link
Collaborator

Horgix commented May 2, 2021

As discussed in #14 comments (#14 (comment)) :

MConvBNReLU must absolutely get eradicated though. It doesn't do anything wrong really, but doesn't fit in the new design & philosophy or Torchelie. If anything, we should construct the PixelCNN with simple ConvBlocks then use torchelie.nn.utils.edit_model to transform all convs into masked convs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Horgix