Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver extension to handle underapproximation #129

Merged
merged 3 commits into from
Mar 1, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove underapprox
vhavlena committed Feb 28, 2024
commit 2a0c7d3396196e6a590da4a012e7d3cec7e82dc8
2 changes: 1 addition & 1 deletion src/smt/theory_str_noodler/theory_str_noodler.cpp
Original file line number Diff line number Diff line change
@@ -902,7 +902,7 @@ namespace smt::noodler {
// save the current assignment to catch it during the loop protection
block_curr_len(lengths, true, false);
return FC_DONE;
} else if (is_lengths_sat == l_false && precision != LenNodePrecision::UNDERAPPROX) {
} else if (is_lengths_sat == l_false /*&& precision != LenNodePrecision::UNDERAPPROX*/) {
// TODO is handling underapprox correct here? is it even safe to underapproximate? we do not have a case where we underapproximate, but for the future
STRACE("str", tout << "len unsat " << mk_pp(lengths, m) << std::endl;);
block_len = m.mk_or(block_len, lengths);