generated from PaulRBerg/hardhat-template
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VEN-2943]: add support for Pendle's getPtToSyRate #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkirka
changed the title
feat: add support for pendle's getPtToSyRate
feat: add support for Pendle's getPtToSyRate
Dec 11, 2024
kkirka
force-pushed
the
feat/pendle-sy-rate
branch
from
December 11, 2024 10:11
de5f34f
to
97d3797
Compare
chechu
changed the title
feat: add support for Pendle's getPtToSyRate
[VEN-2943]: add support for Pendle's getPtToSyRate
Dec 11, 2024
GitGuru7
reviewed
Dec 12, 2024
chechu
reviewed
Dec 21, 2024
kkirka
force-pushed
the
feat/pendle-sy-rate
branch
from
December 23, 2024 17:29
fde5d09
to
79489b4
Compare
chechu
reviewed
Dec 23, 2024
Problem: Some terms were used ambiguously throughout the docs, e.g. "underlying asset" could refer to Pendle market's asset or an SY token or a yield token. Solution: * Use the term "underlying token" to refer to the oracle's underlying token (it can be either the market's asset or the yield token). * Use the term "yield token" to refer to an interest-bearing token wrapped by SY. * Use the term "market's asset" to refer to the underlying asset of the Pendle market. 1 PT will eventually be equivalent to 1 asset at redemption.
kkirka
force-pushed
the
feat/pendle-sy-rate
branch
from
December 23, 2024 17:53
08f530b
to
fb5a4ec
Compare
chechu
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies Pendle oracle to support using yield tokens as a base, as an alternative to using the underlying asset directly. This is the approach recommended by the Pendle team for tokens where redemptions/withdrawals are not guaranteed.