Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/1389 amendments by @kormanowsky #1517

Merged
merged 23 commits into from
Dec 19, 2024
Merged

issues/1389 amendments by @kormanowsky #1517

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c56055c
issues/1389
bonkalol Aug 13, 2024
d762d0e
:art: changelog
bonkalol Aug 13, 2024
a848576
:art:
bonkalol Aug 13, 2024
2eea6c1
Added measure of createBlock and renderList
bonkalol Aug 16, 2024
278e109
fix component name
bonkalol Aug 16, 2024
e202e59
chore: rewrite measurements as decorator
kormanowsky Dec 16, 2024
e6a85e7
chore: shorten if for performance.measure
kormanowsky Dec 16, 2024
3b16f7b
fix: move enableMeasurement check outside of wrapper for original func
kormanowsky Dec 16, 2024
aa97637
chore: use const instead of let for start
Dec 16, 2024
5c4045c
fix: move measurement() call before calling start = perf.now()
Dec 16, 2024
4277479
chore: call() -> apply()
Dec 17, 2024
8b1c407
Merge branch 'v4' into kormanowsky/issues/1389
kormanowsky Dec 17, 2024
c4746ae
fix: try to avoid Symbol() instead of component name in perf report
kormanowsky Dec 18, 2024
190c868
chore: allow measurement name function to return null
kormanowsky Dec 18, 2024
7097b1f
chore: do not measure createElementBlock()
kormanowsky Dec 18, 2024
ad14f57
chore: remove getComponentMeta(), enableMeasurement
kormanowsky Dec 18, 2024
09fc891
Merge branch 'v4' into kormanowsky/issues/1389
kormanowsky Dec 18, 2024
8097ef8
chore: fix linters
kormanowsky Dec 18, 2024
9851e36
chore: fix review comment
kormanowsky Dec 18, 2024
9e68a94
Revert "chore: remove getComponentMeta(), enableMeasurement"
kormanowsky Dec 19, 2024
5bc1593
chore: fix doc
kormanowsky Dec 19, 2024
b6b4efd
fix: IS_PROD check corrected
kormanowsky Dec 19, 2024
f63ccea
chore: :up: version
kormanowsky Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: do not measure createElementBlock()
  • Loading branch information
@kormanowsky
kormanowsky committed Dec 18, 2024
commit 7097b1f5cf3b53a4fde568c7e9741bd3deb34d2d
14 changes: 4 additions & 10 deletions src/core/component/render/wrappers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,16 +271,10 @@ export function wrapCreateBlock<T extends typeof createBlock>(original: T): T {
*/
export function wrapCreateElementBlock<T extends typeof createElementBlock>(original: T): T {
return Object.cast(
wrapWithMeasurement(
function getMeasurementName(this: ComponentInterface) {
return `<${this.componentName.camelize(true)}> create element block`;
},

function createElementBlock(this: ComponentInterface, ...args: Parameters<T>) {
args[3] = normalizePatchFlagUsingProps.call(this, args[3], args[1]);
return resolveAttrs.call(this, original.apply(null, args));
}
)
function createElementBlock(this: ComponentInterface, ...args: Parameters<T>) {
args[3] = normalizePatchFlagUsingProps.call(this, args[3], args[1]);
return resolveAttrs.call(this, original.apply(null, args));
}
);
}

Expand Down