Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings #408

Merged
merged 63 commits into from
Jun 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
ec1a657
Fix most warning and add comments
dANW34V3R Feb 27, 2024
6593341
More fixes
dANW34V3R Feb 27, 2024
43e266b
Fixup tests
dANW34V3R Feb 28, 2024
6b1544b
Handle output of system calls
dANW34V3R Feb 28, 2024
823b7f1
Fix warning for tests in release mode
dANW34V3R Feb 28, 2024
b69318f
Fix commitMicroOps
dANW34V3R Feb 28, 2024
998b8cf
Add default binary
dANW34V3R Mar 6, 2024
a824732
Fix AT_FCWD on Mac
dANW34V3R Mar 6, 2024
0bcbf17
Quash armclang warning
dANW34V3R Mar 13, 2024
a3252c0
Quash armclang float.hh
dANW34V3R Mar 13, 2024
1773f5d
Conditionally include filesystem.h
dANW34V3R Mar 14, 2024
fafb331
Update jenkins comparison values
dANW34V3R Mar 14, 2024
8eb411d
Add pedantic warnings and only give warnings for SimEng
dANW34V3R Mar 14, 2024
c27d3cf
Fix pedantic warnings
dANW34V3R Mar 14, 2024
8ace4dd
Update default binary's path to be absolute. Needed if binary called …
dANW34V3R Mar 15, 2024
c5a4372
Update jenkins comparison values
dANW34V3R Mar 15, 2024
83441d0
Update jenkins for tx2 run
dANW34V3R Mar 15, 2024
796f5bf
Update unit tests
dANW34V3R Mar 15, 2024
c810db5
Update tests to use dynamic stack pointers
dANW34V3R Mar 15, 2024
25b6ccd
Update command line string for OSTest
dANW34V3R Mar 15, 2024
e72941d
Fix cmdLine
dANW34V3R Mar 15, 2024
34d9e96
Turn warnings into errors
dANW34V3R Mar 15, 2024
b01493e
Remove extra semicolons
dANW34V3R Mar 18, 2024
be847ae
Prevent unused tuple member warning
dANW34V3R Mar 18, 2024
23eb995
Clang format
dANW34V3R Mar 18, 2024
ab0a3b6
Pedantic warnings for all tests
dANW34V3R Mar 18, 2024
4c74f63
Build in release mode for CI
dANW34V3R Mar 18, 2024
9ed5edc
Fix warnings in tests
dANW34V3R Mar 19, 2024
8226395
TEMP add Wextra
dANW34V3R Mar 19, 2024
379362a
Change char* to uint8*
dANW34V3R Mar 19, 2024
7aef61e
Remove cast and update initialiser
dANW34V3R Mar 19, 2024
52160f8
Clean up CMake
dANW34V3R Mar 19, 2024
592ff3a
Cleanup
dANW34V3R Mar 20, 2024
6747b0d
Fixes for AppleClang
dANW34V3R Mar 21, 2024
da4d460
Fix pop pragma
dANW34V3R Mar 21, 2024
acf78c0
Clang format
dANW34V3R Mar 21, 2024
b0e2e47
Fixes for SST warnings
dANW34V3R Mar 21, 2024
0c6cc73
Address PR comments
dANW34V3R Mar 22, 2024
f1a3211
PR comments
dANW34V3R Mar 28, 2024
e3f8df9
Address PR comments
dANW34V3R Apr 11, 2024
664476f
Address PR comments
dANW34V3R Apr 11, 2024
3f5632d
Address PR comments
dANW34V3R Apr 29, 2024
68874aa
Remove hex
dANW34V3R May 10, 2024
b4b72c7
Address PR comments
dANW34V3R May 10, 2024
b3da40d
Revert type change
dANW34V3R May 21, 2024
2c5a7d7
Check for warnings when state change not fully initialised
dANW34V3R May 21, 2024
50d040d
Recreate warning to test fixes
dANW34V3R May 21, 2024
753fe5b
Fix SST test framework warnings
dANW34V3R May 22, 2024
bcd9a49
Remove double default
dANW34V3R May 22, 2024
2ffbbe6
Update unit tests to use default program
dANW34V3R May 22, 2024
4c18a4e
Remove bracket from macro fixing all SST tests
dANW34V3R May 23, 2024
30ca287
Add comments to SST framework changes
dANW34V3R May 23, 2024
06562c9
Update default value for expectedBounds
dANW34V3R May 23, 2024
028e0ca
Update use of output when calling realpath
dANW34V3R May 23, 2024
8ad4293
Add brackets to expect macro
dANW34V3R May 24, 2024
7fa166f
Update docs
dANW34V3R May 24, 2024
462f616
Remove TODO
dANW34V3R May 31, 2024
e303bd3
Updated reservation station size data types to be more appropriate fo…
Jun 3, 2024
3801d70
Changed vecTbl to correctly operate with unsigned variables
Jun 3, 2024
5c10446
Removed accidental upstream of test file and added to gitignore
Jun 3, 2024
ceb98f8
Add TODO for SST test framework
dANW34V3R Jun 4, 2024
b09b0de
Alter comments and remove redundant assertion
dANW34V3R Jun 4, 2024
08376f1
Remove unused function from SST test suite
dANW34V3R Jun 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update command line string for OSTest
  • Loading branch information
dANW34V3R committed Mar 15, 2024
commit 25b6ccd2f653c76ae673c614d00ef9cffa68ae8d
5 changes: 4 additions & 1 deletion test/unit/OSTest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ class OSTest : public testing::Test {
const std::vector<std::string> cmdLine = {
SIMENG_SOURCE_DIR "/test/unit/data/stream-aarch64.elf"};

std::vector<std::string> defaultCmdLine = {SIMENG_SOURCE_DIR
"/SimEngDefaultProgram\0"};

simeng::kernel::Linux os;
simeng::kernel::LinuxProcess proc_elf;
simeng::kernel::LinuxProcess proc_hex;
Expand All @@ -49,7 +52,7 @@ TEST_F(OSTest, processElf_stackPointer) {
// cmdLine[0] length will change depending on the host system so final stack
// pointer needs to be calculated manually
// cmdLineSize + 1 for null seperator
const uint64_t cmdLineSize = cmdLine[0].size() + 1;
const uint64_t cmdLineSize = defaultCmdLine[0].size() + 1;
// "OMP_NUM_THREADS=1" + 1 for null seperator
const uint64_t envStringsSize = 18;
// Size of initial stack frame as per LinuxProcess.cc:createStack()
Expand Down