Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate no longer supported projectId and environment config settings #240

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: deprecate no longer supported projectId and environment config settings #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Unleash/UnleashSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
/// <summary>
/// Gets or sets an environment. Used for communication with backend api.
/// </summary>
[Obsolete("No longer supported in recent versions of Unleash, scope API token accordingly instead. Will be removed in the next major version", false)]
public string Environment { get; set; } = "default";

/// <summary>
Expand All @@ -53,6 +54,7 @@
/// <summary>
/// Sets the project to fetch feature toggles for.
/// </summary>
[Obsolete("No longer supported in recent versions of Unleash, scope API token accordingly instead. Will be removed in the next major version", false)]
public string ProjectId { get; set; } = null;

/// <summary>
Expand Down Expand Up @@ -170,9 +172,9 @@
var sb = new StringBuilder("## Unleash settings ##");

sb.AppendLine($"Application name: {AppName}");
sb.AppendLine($"Environment: {Environment}");

Check warning on line 175 in src/Unleash/UnleashSettings.cs

View workflow job for this annotation

GitHub Actions / build 

'UnleashSettings.Environment' is obsolete: 'No longer supported in recent versions of Unleash, scope API token accordingly instead. Will be removed in the next major version'

Check warning on line 175 in src/Unleash/UnleashSettings.cs

View workflow job for this annotation

GitHub Actions / build 

'UnleashSettings.Environment' is obsolete: 'No longer supported in recent versions of Unleash, scope API token accordingly instead. Will be removed in the next major version'
sb.AppendLine($"Instance tag: {InstanceTag}");
sb.AppendLine($"Project Id: {ProjectId}");

Check warning on line 177 in src/Unleash/UnleashSettings.cs

View workflow job for this annotation

GitHub Actions / build 

'UnleashSettings.ProjectId' is obsolete: 'No longer supported in recent versions of Unleash, scope API token accordingly instead. Will be removed in the next major version'

Check warning on line 177 in src/Unleash/UnleashSettings.cs

View workflow job for this annotation

GitHub Actions / build 

'UnleashSettings.ProjectId' is obsolete: 'No longer supported in recent versions of Unleash, scope API token accordingly instead. Will be removed in the next major version'
sb.AppendLine($"Server Uri: {UnleashApi}");
sb.AppendLine($"Sdk version: {SdkVersion}");

Expand Down
Loading