ebay-video: added ability to input shaka config (eBay#2306)

UDAY556 · Oct 30, 2024 · 047647b · 047647b
1 parent 6ecb144
commit 047647b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/.changeset/weak-lemons-dance.md b/.changeset/weak-lemons-dance.md
@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": patch
+---
+
+ebay-video: shaka config can now be added as input
diff --git a/src/components/ebay-video/component.ts b/src/components/ebay-video/component.ts
@@ -73,6 +73,7 @@ interface VideoInput extends Omit<Marko.Input<"video">, `on${string}`> {
     "on-pause"?: (event: PlayPauseEvent) => void;
     "on-volume-change"?: (event: VolumeEvent) => void;
     "on-load-error"?: (err: Error) => void;
+    "shaka-config"?: any;
 }
 
 export interface Input extends WithNormalizedProps<VideoInput> {}
@@ -314,6 +315,7 @@ class Video extends Marko.Component<Input, State> {
 
         // eslint-disable-next-line no-undef,new-cap
         this.player = new shaka.Player(this.video);
+        this.player.configure(this.input.shakaConfig || {});
         this._attach();
 
         this._loadSrc();

diff --git a/src/components/ebay-video/video.stories.ts b/src/components/ebay-video/video.stories.ts
@@ -89,6 +89,11 @@ export default {
             description:
                 "True/False to keep or remove volume slider. Default is False",
         },
+        shakaConfig: {
+            description:
+                "The Shaka player [configuration object](https://shaka-player-demo.appspot.com/docs/api/tutorial-config.html). This allows users to control Shaka player.",
+            control: { type: "object" },
+        },
 
         source: {
             name: "@source",
@@ -228,7 +233,7 @@ Standard.args = {
             src: "https://ir.ebaystatic.com/cr/v/c1/ebayui/video/v1/playlist.mpd",
             type: "dash",
         },
-    ],
+    ]
 };
 Standard.parameters = {
     docs: {
@@ -253,6 +258,11 @@ ios.args = {
             type: "dash",
         },
     ],
+    shakaConfig: {
+        streaming: {
+            lowLatencyMode: true,
+        }
+    }
 };
 
 ios.parameters = {