From 02884682dbe2cc332e1bca2090e9f07a79840a04 Mon Sep 17 00:00:00 2001 From: Andrew Bradley Date: Tue, 17 May 2022 23:50:53 -0400 Subject: [PATCH] cleanup misc markdown files --- development-docs/README.md | 10 ++++++++++ TODOs.md => development-docs/nodenextNode16.md | 7 ++++++- notes2.md => development-docs/rootDirOutDirMapping.md | 2 ++ NOTES.md => development-docs/yarnPnpInterop.md | 4 +--- notes1.md | 9 --------- 5 files changed, 19 insertions(+), 13 deletions(-) create mode 100644 development-docs/README.md rename TODOs.md => development-docs/nodenextNode16.md (88%) rename notes2.md => development-docs/rootDirOutDirMapping.md (93%) rename NOTES.md => development-docs/yarnPnpInterop.md (96%) delete mode 100644 notes1.md diff --git a/development-docs/README.md b/development-docs/README.md new file mode 100644 index 000000000..17ab824fb --- /dev/null +++ b/development-docs/README.md @@ -0,0 +1,10 @@ +This directory contains a variety of documents: + +- notes +- old to-do lists +- design ideas from when I implemented various features +- templates for drafting release notes +- etc + +It is useful to me to keep these notes. If you find their presence +confusing, you can safely ignore this directory. diff --git a/TODOs.md b/development-docs/nodenextNode16.md similarity index 88% rename from TODOs.md rename to development-docs/nodenextNode16.md index f24891cf4..89ce02c9a 100644 --- a/TODOs.md +++ b/development-docs/nodenextNode16.md @@ -1,4 +1,9 @@ -#TODOs +# Adding support for NodeNext, Node16, `.cts`, `.mts`, `.cjs`, `.mjs` + +*This feature has already been implemented. Here are my notes from when +I was doing the work* + +## TODOs Implement node module type classifier: - if NodeNext or Node12: ask classifier for CJS or ESM determination diff --git a/notes2.md b/development-docs/rootDirOutDirMapping.md similarity index 93% rename from notes2.md rename to development-docs/rootDirOutDirMapping.md index 93e6bac65..db552772d 100644 --- a/notes2.md +++ b/development-docs/rootDirOutDirMapping.md @@ -1,3 +1,5 @@ +## Musings about resolving between rootDir and outDir + When /dist and /src are understood to be overlaid because of src -> dist compiling /dist/ /src/ diff --git a/NOTES.md b/development-docs/yarnPnpInterop.md similarity index 96% rename from NOTES.md rename to development-docs/yarnPnpInterop.md index 0f0cbf15d..816f921ff 100644 --- a/NOTES.md +++ b/development-docs/yarnPnpInterop.md @@ -1,6 +1,4 @@ -*Delete this file before merging this PR* - -## PnP interop +## Yarn PnP interop Asked about it here: https://discord.com/channels/226791405589233664/654372321225605128/957301175609344070 diff --git a/notes1.md b/notes1.md deleted file mode 100644 index ee561f48d..000000000 --- a/notes1.md +++ /dev/null @@ -1,9 +0,0 @@ -const patterns = getRegularExpressionsForWildcards(specs, basePath, usage); -const pattern = patterns.map(pattern => `(${pattern})`).join("|"); -// If excluding, match "foo/bar/baz...", but if including, only allow "foo". -const terminator = usage === "exclude" ? "($|/)" : "$"; -return `^(${pattern})${terminator}`; - - -const pattern = spec && getSubPatternFromSpec(spec, basePath, usage, wildcardMatchers[usage]); -return pattern && `^(${pattern})${usage === "exclude" ? "($|/)" : "$"}`;