Add valid chars test for the property of metadata (Modernizr#2601)

* Add check for metadata.property to be lowercase * Improve test for metadata.property values * Refactor to keep polyfill test block
TusharNaugain · Sep 8, 2020 · 3ccc7f1 · 3ccc7f1
1 parent bd06d5a
commit 3ccc7f1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/metadata.js b/lib/metadata.js
@@ -85,6 +85,14 @@ function metadata(cb) {
       }
       metadata.polyfills = pfs;
 
+      //metadata.property can only have lowercase alphanumeric and dashes
+      const properties = Array.isArray(metadata.property) ? metadata.property : [metadata.property];
+      properties.forEach(function (property) {
+        if (!property.match(/^[a-z0-9-]+$/)) {
+          throw new Error(metadata.name + ' : ' + property + ': Property can only have lowercase alphanumeric characters and dashes ' )
+        }
+      })
+
       if (!metadata.async) {
         metadata.async = false;
       }

diff --git a/test/node/lib/metadata.js b/test/node/lib/metadata.js
@@ -102,6 +102,18 @@ describe('cli/metadata', function() {
     expect(metadata).to.throw(/Minimal metadata not found/);
   });
 
+  it('should throw if property contains uppercase characters and/or special symbols except dashes', function() {
+
+    var metadata = proxyquire(root + 'lib/metadata', {
+      'fs': {
+        'readFileSync': function() {
+          return '/*! { "name": "fake", "property": "U_pper-case123"}!*/ define([],';
+        }
+      }
+    });
+    expect(metadata).to.throw(/Property can only have lowercase alphanumeric characters and dashes/);
+  });
+
   it('should throw if polyfill is incorrectly configured', function() {
 
     var metadata = proxyquire(root + 'lib/metadata', {