-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Enzyme and reexport ADTypes.AutoEnzyme
#1887
Draft
devmotion
wants to merge
87
commits into
master
Choose a base branch
from
dw/enzyme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 77 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
29017e7
Add support for Enzyme
devmotion fdf0d43
Merge branch 'master' into dw/enzyme
yebai d7ef23e
Merge branch 'master' into dw/enzyme
yebai 874b9e7
Merge branch 'master' into dw/enzyme
devmotion 43ef4c4
Apply suggestions from code review
devmotion 3e5841f
Add Enzyme to test dependencies
devmotion 66bce4e
Test Enzyme
devmotion 7890134
Update ad.jl
devmotion 120e9f5
Merge branch 'master' into dw/enzyme
yebai f4bd1bf
Update Project.toml
yebai c8e01d0
Update advi.jl
yebai d8d7729
Merge branch 'master' into dw/enzyme
yebai 1d1dba0
Merge branch 'master' into dw/enzyme
yebai 946e594
Do not call `Bijectors.setadbackend`
devmotion edd19a4
Merge branch 'master' into dw/enzyme
yebai e9eedd1
Update Project.toml
devmotion 9cfb589
Merge branch 'master' into dw/enzyme
yebai cf03624
Merge branch 'master' into dw/enzyme
yebai 0a5c42b
Merge branch 'master' into dw/enzyme
devmotion 8d8d031
Address comments
devmotion e591630
Update runtests.jl
devmotion 568cdac
Update Project.toml
devmotion d00f297
Merge branch 'master' into dw/enzyme
devmotion 6f0bf67
Update Project.toml
devmotion 5ba7ac6
Update Project.toml
devmotion 162755b
Test against Enzyme#main
devmotion ce26c3c
Merge branch 'master' into dw/enzyme
devmotion b35ab28
Merge branch 'master' into dw/enzyme
yebai e44e756
Try addr13 branch
devmotion 1f1b114
Update runtests.jl
devmotion 1b3fa60
Merge branch 'master' into dw/enzyme
devmotion aad8a1a
Merge branch 'master' into dw/enzyme
yebai bb795e6
Disable Gibbs tests temporarily
yebai 1c7f20e
Update test/Project.toml
yebai 2a40639
Merge branch 'master' into dw/enzyme
yebai 1b87d2e
Merge branch 'master' into dw/enzyme
yebai dad6b97
Merge branch 'master' into dw/enzyme
yebai 012a0cb
disable tests unrelated to enzyme + limit CI to avoid over-use of res…
torfjelde 552b01f
Merge branch 'master' into dw/enzyme
sunxd3 5777344
import `AutoEnzyme`
sunxd3 1ffdbca
Merge branch 'master' into dw/enzyme
sunxd3 121df7d
Test hmc only
sunxd3 a164707
Update sghmc.jl
wsmoses 97f1fb6
Update runtests.jl
wsmoses c7b6cf4
disable Type unstable getfield
wsmoses efdd8e7
use release
wsmoses 2fdf546
Remove seemingly unnecessary definition
devmotion 4d8cd23
Run tests on Enzyme#main again
devmotion 47292a7
Merge branch 'master' into dw/enzyme
wsmoses 4b00f0d
Merge branch 'master' into dw/enzyme
wsmoses 889275e
Merge branch 'master' into dw/enzyme
yebai 578967b
Merge branch 'master' into dw/enzyme
yebai b8296be
Test with cholesky fixes
devmotion 0385250
Merge branch 'master' into dw/enzyme
yebai 24cc3a9
Merge branch 'master' into dw/enzyme
yebai 2b54d69
Update Project.toml
yebai 2823a41
Update Turing.jl
yebai f4c72bd
Merge remote-tracking branch 'origin/master' into dw/enzyme
mhauru 6b7159c
Merge branch 'master' into dw/enzyme
devmotion 0c376a6
Attempt at fix for `bnn` tests as outlined in #2277
torfjelde 76b5e48
Update test/runtests.jl
yebai 784b8cb
Update runtests.jl
yebai 5bfd06d
remove implicit usage of `hvcat`
torfjelde 836e29b
Merge branch 'master' into dw/enzyme
yebai e299042
Merge branch 'master' into dw/enzyme
devmotion d4d55d6
Merge branch 'master' into dw/enzyme
wsmoses ce13e03
Re-activate CIs disabled for Enzyme testing
torfjelde 19a3332
Merge branch 'master' into dw/enzyme
yebai e2c0693
Re-enable tests with other AD backends
devmotion 387018d
Merge branch 'master' into dw/enzyme
devmotion 2115d52
Load `@test_broken`
devmotion b7ad9db
Merge branch 'master' into dw/enzyme
yebai 1c7319b
Merge remote-tracking branch 'origin/master' into dw/enzyme
mhauru 79d057c
Bump Enzyme to 0.13 in tests
mhauru c98bbc9
Run JuliaFormatter on more files, remove trailing whitespace
mhauru aa9abd6
Merge branch 'mhauru/more-formatting' into dw/enzyme
mhauru 9d39193
Restore compat with Enzyme v0.12
mhauru 66cd80a
Import Enzyme in abstractmcmc and gibbs tests
mhauru ec34e41
Add Enzyme imports to a couple of other tests files
mhauru 120230a
Remove unnecessary version conditions in tests
mhauru 98f2c2b
Merge branch 'master' into dw/enzyme
yebai 2c88d59
Merge branch 'master' into dw/enzyme
devmotion f9165fa
Update Project.toml
devmotion e77aa54
Merge branch 'master' into dw/enzyme
mhauru 5698212
Dump DPPL to 0.31
mhauru 8bff239
Merge remote-tracking branch 'origin/master' into dw/enzyme
mhauru 20b055e
Fix ADTypeCheck tests for Enzyme, add testing both Reverse and Forwar…
mhauru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's export this as
Turing.Experimental.AutoEnzyme
until Enzyme becomes more stable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the threshold for being considered stable here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhauru and @penelopeysm probably have a lot more experience on this.
My heuristic threshold:
for a continuous period of 8 weeks.