Update canton tests to pre 0.23.0 release (digital-asset#9356)

- switch lf_version to stable and latest from legacy - enable non-contract-key race condition tests in regular canton deployment (on non-unique contract key domain) - reenable temporarily disabled semantic tests (see KVL-876 - fyi @hubert-da) changelog_begin changelog_end
TuranDev · Apr 8, 2021 · 4c231dc · 4c231dc
1 parent bc4e00b
commit 4c231dc
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -952,7 +952,7 @@ java_import(
     jars = glob(["lib/**/*.jar"]),
 )
 """,
-    sha256 = "81e590a6854eaaf724356c0b7068502174de6457af6ec2a24624b0698eeb7362",
-    strip_prefix = "canton-community-0.21.0",
-    urls = ["https://www.canton.io/releases/canton-community-0.21.0.tar.gz"],
+    sha256 = "9fb38c922d302c94e200c161ec8467ea39f4c31c9a7fad0b32f1493170a51fa7",
+    strip_prefix = "canton-community-0.23.0-SNAPSHOT",
+    urls = ["https://www.canton.io/releases/canton-community-20210407.tar.gz"],
 )
diff --git a/ledger/ledger-api-test-tool-on-canton/BUILD.bazel b/ledger/ledger-api-test-tool-on-canton/BUILD.bazel
@@ -61,9 +61,10 @@ conformance_test(
         "@jq_dev_env//:jq",
         "@jdk11_nix//:bin/java",
     ],
-    # FIXME: drop the following line once canton-test-runner supports LF 1.12
-    lf_versions = ["legacy"],
-    # lf_versions = ["stable", "latest"],
+    lf_versions = [
+        "stable",
+        "latest",
+    ],
     ports = [
         5011,
         5021,
@@ -80,9 +81,8 @@ conformance_test(
         ",ParticipantPruningIT" +  # see "conformance-test-participant-pruning" below
         ",ConfigManagementServiceIT,LedgerConfigurationServiceIT" +  # dynamic config management not supported by Canton
         ",ClosedWorldIT" +  # Canton currently fails this test with a different error (missing namespace in "unallocated" party id)
-        ",RaceConditionIT" +
-        # Some of gRPC status codes changed from INVALID_ARGUMENT to ABORTED (see https://github.com/digital-asset/daml/pull/9218):
-        ",SemanticTests:SemanticDoubleSpendBasic,SemanticTests:SemanticDoubleSpendShared,SemanticTests:SemanticPrivacyProjections,SemanticTests:SemanticDivulgence",
+        # Excluding tests that require contract key uniqueness and RWArchiveVsFailedLookupByKey (finding a lookup failure after contract creation)
+        ",RaceConditionIT:WWDoubleNonTransientCreate,RaceConditionIT:WWArchiveVsNonTransientCreate,RaceConditionIT:RWTransientCreateVsNonTransientCreate,RaceConditionIT:RWArchiveVsFailedLookupByKey",
     ],
 ) if not is_windows else None
 
@@ -101,9 +101,10 @@ conformance_test(
         "@jq_dev_env//:jq",
         "@jdk11_nix//:bin/java",
     ],
-    # FIXME: drop the following line once canton-test-runner supports LF 1.12
-    lf_versions = ["legacy"],
-    # lf_versions = ["stable", "latest"],
+    lf_versions = [
+        "stable",
+        "latest",
+    ],
     ports = [
         5011,
         5021,
@@ -137,6 +138,10 @@ conformance_test(
         "@jq_dev_env//:jq",
         "@jdk11_nix//:bin/java",
     ],
+    lf_versions = [
+        "stable",
+        "latest",
+    ],
     ports = [
         5011,
         5021,

diff --git a/ledger/ledger-api-test-tool-on-canton/canton-test-runner.sh b/ledger/ledger-api-test-tool-on-canton/canton-test-runner.sh
@@ -6,7 +6,7 @@ set -e
 set -u
 set -o pipefail
 
-# Canton has some issues with JDK8 so we run it with JDK11.
+# Canton requires JDK11 in production to avoid ForkJoinPool deadlocks on older JDKs so we run it with JDK11.
 JAVA="$(rlocation jdk11_nix/bin/java)"
 
 CANTON_COMMAND=(