Adding Posts analytics React app #21878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzimon
force-pushed
the
posts-app
branch
2 times, most recently
from
ac50b8e to
452d374
Compare
peterzimon
force-pushed
the
posts-app
branch
from
45f08ac to
09d9e08
Compare
allouis
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Left a few comments - overall looks good but there are a lot of files with missing newlines at the end, which I think they should have - EditorConfig should be enforcing that for us.
Also the change to vite config in the admin-x-framework package, I'm not sure I fully understand that
allouis
reviewed
Dec 18, 2024
peterzimon
force-pushed
the
posts-app
branch
from
09d9e08 to
08a9b46
Compare
peterzimon
force-pushed
the
posts-app
branch
from
6d7c852 to
6ac6b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/DES-1021/create-posts-app
Part of establishing React patterns in Ghost is to build a well-defined and fairly self-encapsulated app through which we can test assumptions and define best practices. Our guinea pig is Post analytics for this purpose. This PR creates a new React app (posts) using Shade (the new design system).