Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute method does not pass exception as a parameter in Fallback method #27

Open
vnadar opened this issue Nov 15, 2017 · 0 comments
Open

Execute method does not pass exception as a parameter in Fallback method #27

vnadar opened this issue Nov 15, 2017 · 0 comments

Comments

@vnadar
Copy link

vnadar commented Nov 15, 2017

Currently IHystrixCommand has Execute method with two overloads, but both does not provide exception parameter in fallback method. InnerException is valuable in case any exception occurred during execution, then in fallback we can log and throw an exception based on that.

Below are the two overloads.
T Execute(Func primaryFunction, CancellationTokenSource cancellationTokenSource = null);
T Execute(Func primaryFunction, Func fallbackFunction, CancellationTokenSource cancellationTokenSource = null)
@vnadar vnadar changed the title InnerException not exposed as a parameter in Fallback method InnerException does not exposed as a parameter in Fallback method Nov 15, 2017
@vnadar vnadar changed the title InnerException does not exposed as a parameter in Fallback method InnerException does not pass exception as a parameter in Fallback method Nov 15, 2017
@vnadar vnadar changed the title InnerException does not pass exception as a parameter in Fallback method Execute method does not pass exception as a parameter in Fallback method Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vnadar