Bug: __get_embeddings Method to Handle Both List and Single String input #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Inputs Description: This PR updates the __get_embeddings method to handle both a list of strings and a single string input. Previously, the method only supported a list of strings. With this update, the method checks the type of the texts parameter and processes it accordingly. filter was a local variable inside if condition, hence rest of the code was failing. Changes: Added a type check for the texts parameter to differentiate between a list of strings and a single string. If texts is a list, the method processes each string individually and returns the list of query vectors. If texts is a single string, the method processes it and returns a single-element list containing the query vector.
Update __get_embeddings Method to Handle Both List and Single String …
|
|
python296
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the __get_embeddings method to handle both a list of strings and a single string input. Previously, the method only supported a list of strings. With this update, the method checks the type of the texts parameter and processes it accordingly.
Added a type check for the texts parameter to differentiate between a list of strings and a single string.
If texts is a list, the method processes each string individually and returns the list of query vectors.
If texts is a single string, the method processes it and returns a single-element list containing the query vector.
Related Issues
Method __get_embeddings in qdrant DB.
Solution and Design
Test Plan
Type of change
Checklist