Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiresfix #82

Open
offmybach opened this issue Jan 26, 2024 · 9 comments
Open

hiresfix #82

offmybach opened this issue Jan 26, 2024 · 9 comments

Comments

@offmybach
Copy link

unable to locate hiresfix node anywhere. will not load in any of my workflows or the png included.

image

@TinyTerra
Copy link
Owner

TinyTerra commented Jan 27, 2024

This looks as though the nodes aren't installed at all / correctly?

@offmybach
Copy link
Author

This looks as though the nodes aren't installed at all / correctly?

They are installed but not loading at all. I will install again. There were other workflows with ttn nodes that wouldn't learn either

@offmybach
Copy link
Author

image

should be installed

@TinyTerra
Copy link
Owner

Does the console show [tinyterranodes] loaded on startup? Might be worthwhile deleting the entire tinyterra folder and re-installing it if not.. Not entirely sure what else could be causing it without the console log

@offmybach
Copy link
Author

tried again and still folder present but says failed to install in manager

@TinyTerra
Copy link
Owner

TinyTerra commented Feb 4, 2024

Have you tried cloning the repository into the custom notes folder manually, instead of via manager?

@offmybach
Copy link
Author

Yes and this was error- which I don't understand
[tinyterraNodes] Loaded
Traceback (most recent call last):
File "D:\ComfyUI_windows_portable\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1893, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "D:\ComfyUI_windows_portable\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes_init
.py", line 171, in
shutil.rmtree(web_extension_path)
File "shutil.py", line 759, in rmtree
File "shutil.py", line 622, in _rmtree_unsafe
File "shutil.py", line 620, in _rmtree_unsafe
PermissionError: [WinError 5] Access is denied: 'D:\ComfyUI_windows_portable\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\web\extensions\tinyterraNodes\ttN.js'

Cannot import D:\ComfyUI_windows_portable\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_tinyterraNodes module for custom nodes: [WinError 5] Access is denied: 'D:\ComfyUI_windows_portable\new_ComfyUI_windows_portable_nvidia_cu121_or_cpu\ComfyUI_windows_portable\ComfyUI\web\extensions\tinyterraNodes\ttN.js'
[comfy_mtb] | INFO -> loaded 65 nodes successfuly
FaceDetailer: Model directory already exists
FaceDetailer: Model already exists
Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success!
Total VRAM 8192 MB, total RAM 32433 MB
xformers version: 0.0.23.post1
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
VAE dtype: torch.bfloat16
Patching UNetModel.forward
UNetModel.forward has been successfully patched.

@TinyTerra
Copy link
Owner

Apologies for the delay on this,
It is a permission error removing the ttN web folder - that needs to be run as admin.
However i've also updated to not require this in (0f86153)

@KINGLIFER
Copy link

for some reason ttN hiresfixScale does not do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants