feat(validation): support multiple delimiters, and return multiple validation errors, and return headers #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. I am currently in China and it’s hard for me to review it appropriately. Could you describe the changes and why they were necessary? That would be great, thanks! |
|
Updated description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some additional validations to return a list of columns that failed to be parsed, as currently it returns the column that failed to be parsed. In addition, I have added a feature to return the headers of the csv, and also another validation that if any row has more columns than the indices, it returns an error - for instance having 4 columns, but rows contain more than 4 columns.
The idea is to return a list of validations to the user so that the majority of the errors can be fixed without re-validating the csv again - for instance avoiding uploading the csv to the server and validating which would save bandwidth and time