Renaming

ThomasBouche · Jan 10, 2025 · 4d3dc88 · 4d3dc88
1 parent 51a57b7
commit 4d3dc88
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/meteole/forecast.py b/src/meteole/forecast.py
@@ -370,7 +370,7 @@ def _get_coverage_description(self, coverage_id: str) -> dict:
         response = self._client.get(url, params=params)
         return xmltodict.parse(response.text)
 
-    def _grib_str_to_df(self, grib_str: bytes) -> pd.DataFrame:
+    def _grib_bytes_to_df(self, grib_str: bytes) -> pd.DataFrame:
         """
         Converts GRIB data (in binary format) into a pandas DataFrame.
 
@@ -440,7 +440,7 @@ def _get_data_single_forecast(
             long=long,
         )
 
-        df = self._grib_str_to_df(grib_str)
+        df = self._grib_bytes_to_df(grib_str)
 
         # Drop and rename columns
         df.drop(columns=["surface", "valid_time"], errors="ignore", inplace=True)

diff --git a/tests/test_forecasts.py b/tests/test_forecasts.py
@@ -156,10 +156,10 @@ def test_get_coverage_description(self, mock_get_request, mock_get_capabilities)
         self.assertIn("wcs:CoverageDescriptions", description)
 
     @patch("meteole._arome.AromeForecast.get_capabilities")
-    @patch("meteole._arome.AromeForecast._grib_str_to_df")
+    @patch("meteole._arome.AromeForecast._grib_bytes_to_df")
     @patch("meteole._arome.AromeForecast._get_coverage_file")
-    def test_get_data_single_forecast(self, mock_get_coverage_file, mock_grib_str_to_df, mock_get_capabilities):
-        mock_grib_str_to_df.return_value = pd.DataFrame({"data": [1, 2, 3]})
+    def test_get_data_single_forecast(self, mock_get_coverage_file, mock_grib_bytes_to_df, mock_get_capabilities):
+        mock_grib_bytes_to_df.return_value = pd.DataFrame({"data": [1, 2, 3]})
 
         forecast = AromeForecast(
             self.client,
@@ -179,13 +179,13 @@ def test_get_data_single_forecast(self, mock_get_coverage_file, mock_grib_str_to
         self.assertTrue("data" in df.columns)
 
     @patch("meteole._arome.AromeForecast.get_capabilities")
-    @patch("meteole._arome.AromeForecast._grib_str_to_df")
+    @patch("meteole._arome.AromeForecast._grib_bytes_to_df")
     @patch("meteole._arome.AromeForecast._get_coverage_file")
     def test_get_data_single_forecast_with_height(
-        self, mock_get_coverage_file, mock_grib_str_to_df, mock_get_capabilities
+        self, mock_get_coverage_file, mock_grib_bytes_to_df, mock_get_capabilities
     ):
         mock_get_coverage_file.return_value = ""
-        mock_grib_str_to_df.return_value = pd.DataFrame({"data": [1, 2, 3], "heightAboveGround": ["2", "2", "2"]})
+        mock_grib_bytes_to_df.return_value = pd.DataFrame({"data": [1, 2, 3], "heightAboveGround": ["2", "2", "2"]})
 
         forecast = AromeForecast(
             self.client,