-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning. #6716
Fix deprecation warning. #6716
Conversation
Thanks for the PR, but this break our build bot. As Theano ins't developed anymore, we won't change the requirement. Can you make this work with the older Python version that we still support? Python 2.7, 3.4-3.6 |
@nouiz OK, working on it. I'm afraid I don't have a full setup for Theano development here, so I'm relying on your build bot to test. If this works, you can squash merge it, otherwise I will try again until I get something that passes tests. |
@nouiz I'm confused by the test results: when I look at https://travis-ci.org/Theano/Theano/jobs/573893290 I see that the test failed, but AFAICT it's because the code isn't formatted to comply with |
we fix the pep8 and flake8 version for tests. So this shouldn't be a problem. But there is one:) |
master failed. I do not understand what changes could have caused this. |
There's also something bad going on testing with python 3.4:
We should probably move this discussion to a separate issue where it's easier to find. Note that I have been discussing this with @twiecki and he also tried travis, which now failed completely on |
I fixed the master. Can you rebase this PR? |
Change the import of `Iterable` from `collections.Iterable` to `collections.abc.Iterable` to future-proof against Python 3.7.8.
@nouiz OK, rebased and force-pushed. Note that the history of this PR is uninteresting, so if it looks good, you should just squash-merge it... |
Thanks. Merging. |
Change the import of
Iterable
fromcollections.Iterable
tocollections.abc.Iterable
to future-proof against Python 3.7.8.Caught this warning when running the PyMC3 tests.