Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Full NodeJS Path: Rewrite headings to follow sentence case Style Guide #25861

Closed
1 of 2 tasks
ManonLef opened this issue Jul 19, 2023 · 61 comments
Closed
1 of 2 tasks

Fix: Full NodeJS Path: Rewrite headings to follow sentence case Style Guide #25861

ManonLef opened this issue Jul 19, 2023 · 61 comments
Assignees
@ManonLef
Labels
Type: Easy Fix Involves a minor fix such as grammar, syntax, etc. Type: Good First Issue Good for beginner contributors Type: Node/JS Involves the full stack JavaScript path

Comments

@ManonLef
Copy link
Member

ManonLef commented Jul 19, 2023 •
edited
Loading

Describe your suggestion

Our Style Guide requires all headings to be in sentence case. This means many lessons need to be reviewed and corrected as needed.

I would like to open this up for first-time contributors or those still very new to contributing to work on. You can follow the links to see how big the sections are. Some will have only a few lessons and some will have quite a lot more. Feel free to pick one you feel comfortable with.

Some sections might have been corrected already but it's good to review them to make sure nothing is missed.

Example:

### Knowledge Check

should be changed to

### Knowledge check

Guidance:

  • Comment on this issue to let us know you'd like to get a section assigned to you. You can also ask for a specific one
  • Please wait until you are assigned by a maintainer before starting to work on this issue to avoid multiple people working on the same lessons
  • Make sure to read the contributing guide before starting your first contribution
  • Please add the following to your PR in the Issues section: Related to #25861 , since this issue is divided into sections, individual PR's should NOT INCLUDE the closes issue link.

Progress and assignees table

Section(s) Assignee completed
Intermediate HTML and CSS Course ------------- -------------
Intermediate HTML and CSS && Intermediate CSS Concepts @amc131 ✅ #25894
Forms && Grid @kristenmazza ✅ #25866
JavaScript Course ------------- -------------
Introduction && Organizing your JavaScript Code @fabulousgk ✅ #25864
JavaScript in the Real World && Asynchronous JavaScript and APIs @therealseanwallace ✅ #25879
A Bit of Computer Science @hmzq-404 ✅ #25880
Testing JS && Intermediate Git @fabulousgk ✅ #25957
Advanced HTML and CSS ------------- -------------
All Lessons (has recently been updated so little to no work) @Hoslok-1 ✅ #25910
React (NEW) ------------- -------------
Intro && Getting Started @OmarNaguib ✅ #25865
States and Effects && Class Components @RazvanBugoi ✅ #25932
React Testing && The React Ecosystem @Babb2000 ✅ #25896
More React Concepts && React and the Backend && Conclusion @JustWaveThings ✅ #25886
NodeJS ------------- -------------
Introduction to NodeJS && MongoDB @YamamJamal ✅ #25945
Express & Mongoose && Authentication && APIs @F4OST ✅ #25892 #25893
Testing Express && Full Stack Projects && FINAL PROJECT @Hoslok-1 ✅ #25910
Getting Hired ------------- -------------
Preparing for Your Job Search @aaronlmjohnson ✅ #25863
Applying to and Interviewing for Jobs @latsonj ✅ #25907

Path

Node / JS

Lesson Url

https://www.theodinproject.com/paths/full-stack-javascript

Checks

(Optional) Discord Name

ManonL (feel free to tag me there in public if you need help while assigned here)

(Optional) Additional Comments

No response
@ManonLef ManonLef added Type: Good First Issue Good for beginner contributors Status: Help Wanted This issue can be assigned to other contributors Type: Node/JS Involves the full stack JavaScript path Type: Easy Fix Involves a minor fix such as grammar, syntax, etc. labels Jul 19, 2023
@ManonLef ManonLef changed the title Full Advanced NodeJS Path: Rewrite headings to follow sentence case Style Guide Fix: Full Advanced NodeJS Path: Rewrite headings to follow sentence case Style Guide Jul 19, 2023
@ManonLef ManonLef changed the title Fix: Full Advanced NodeJS Path: Rewrite headings to follow sentence case Style Guide Fix: Full NodeJS Path: Rewrite headings to follow sentence case Style Guide Jul 19, 2023
@ManonLef ManonLef self-assigned this Jul 19, 2023
@YamamJamal
Copy link
Contributor

Hello, I am a student getting a degree in computer science and in an open source course and looking to contribute to an open source project for the first time. I think this would be appropriate for me since I this would be my very first time contributing! I would like to work on the Introduction to NodeJS && MongoDB section. It would be very much appreciated and thank you!

@ManonLef
Copy link
Member Author

You've got it @YamamJamal ! Thank you for doing this

@hmzq-dev
Copy link
Contributor

Can I work on the A bit of Computer Science lessons?

@ManonLef
Copy link
Member Author

Absolutely @hmzq-404 ! Thank you!

@amc131
Copy link
Contributor

amc131 commented Jul 19, 2023

I've made a small contribution before, but I can help as well unless you have enough first time contributors

@ManonLef
Copy link
Member Author

@amc131 this is open to fairly new contributors as well. Any preference or would you like me to put your name on the first one in the table?

@amc131
Copy link
Contributor

amc131 commented Jul 19, 2023

@ManonLef No preference, I can help with any!

@aaronlmjohnson
Copy link
Contributor

Hi, I'm looking to make some first time contributions. Could I work on the "Preparing for Your Job Search" section?

@ManonLef
Copy link
Member Author

@aaronlmjohnson all yours!

@amc131 I added you as well in the table!

Thanks you both 🥳

@OmarNaguib
Copy link
Contributor

OmarNaguib commented Jul 19, 2023 •
edited
Loading

Would be my second contribution, first one was 2 minutes ago :D .
Would like to help, I can take something from react.

@ManonLef
Copy link
Member Author

ManonLef commented Jul 19, 2023 •
edited
Loading

@OmarNaguib that's wonderful! Any preference or would you like to be assigned a random one from React?

@OmarNaguib
Copy link
Contributor

first one is good

@Unique-Pixels
Copy link
Contributor

Hello, I would do one of these as well. Just assign me one please!

@ManonLef
Copy link
Member Author

ManonLef commented Jul 19, 2023 •
edited
Loading

you've got it @fabulousgk !

@kristenmazza
Copy link
Contributor

I just made my first contribution with the foundation headings and would love some more practice. I'm happy with any section available.

@ManonLef
Copy link
Member Author

Added you @kristenmazza ☺️ thank you!

@Hoslok-1
Copy link
Contributor

Hoslok-1 commented Jul 21, 2023 •
edited
Loading

You were right! It was in react. I've changed the headings and opened a PR. I think I did alright in my finals, I'll see in a few days when the results come haha. Thanks for asking :) .

@ManonLef
Copy link
Member Author

Hi @KadeKorn and @YamamJamal , checking in to see if you need any help with this. Just let me know if you do!

@RazvanBugoi RazvanBugoi mentioned this issue Jul 23, 2023
Merged
7 tasks
@ManonLef ManonLef assigned RazvanBugoi and unassigned RazvanBugoi and Babb2000 Jul 23, 2023
@shady54
Copy link

shady54 commented Jul 24, 2023

Hi @ManonLef ,

Is anything open,
I have never contributed to open source. Could you please assign me something.

@ManonLef
Copy link
Member Author

@shady54 thanks for being willing to help out! There's currently nothing open on this issue. You can always have a look through the issues with status help wanted and see if any are labeled with good first issue.

I'll also soon be opening up this issue for the Ruby path to wrap it up.

@ManonLef
Copy link
Member Author

@KadeKorn and @YamamJamal , I'd really like to start wrapping up this issue. Could you give me an indication of your progress please?

@YamamJamal
Copy link
Contributor

@KadeKorn and @YamamJamal , I'd really like to start wrapping up this issue. Could you give me an indication of your progress please?

I will have it done today, sorry for the delay!

@ManonLef
Copy link
Member Author

@YamamJamal no problem! I will put a more clear time expectation on it next time as well. Working with so many people on one issue and wanting to wrap up the curriculum to avoid too many merge conflicts made this one special. Usually there's less rush to any issues you volunteer on. Thank you for doing this <3

@YamamJamal YamamJamal mentioned this issue Jul 24, 2023
Merged
7 tasks
@shady54
Copy link

shady54 commented Jul 24, 2023

@ManonLef -- Thank you

@KadeKorn
Copy link

@KadeKorn and @YamamJamal , I'd really like to start wrapping up this issue. Could you give me an indication of your progress please?

Hello @ManonLef,
I believe I finished that issue. Please let me know if I did it wrong and I will be happy to re-push it.
This is my first contribution, so please let me know if I need to do it again.
Thank you,
-Kade

@ManonLef
Copy link
Member Author

ManonLef commented Jul 24, 2023 •
edited
Loading

@KadeKorn I didn't see a PR come by for it. Did you open a PR from the fork of your curriculum repo? If you're unsure how to do this: here's the section in the contributing guide about PR's

@KadeKorn KadeKorn removed their assignment Jul 25, 2023
@KadeKorn
Copy link

@ManonLef, I please unassign me from this. Apologies. Thank you for your time

@ManonLef
Copy link
Member Author

Seems there are two sections open for someone to pick up: Testing JS && Intermediate Git. Just let me know if you'd like to be assigned!

@Unique-Pixels
Copy link
Contributor

I can knock them out unless you want to save for someone new

@ManonLef
Copy link
Member Author

@fabulousgk that would be great thank you! It would be nice to wrap this one up and enjoy a small break for the final path!

@Unique-Pixels Unique-Pixels mentioned this issue Jul 25, 2023
Merged
7 tasks
@ManonLef
Copy link
Member Author

You did it! Thanks so much to everyone that contributed 🎉

@ManonLef ManonLef removed the Status: Help Wanted This issue can be assigned to other contributors label Jul 25, 2023
@headlessNode headlessNode mentioned this issue Aug 21, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManonLef ManonLef

Labels
Type: Easy Fix Involves a minor fix such as grammar, syntax, etc. Type: Good First Issue Good for beginner contributors Type: Node/JS Involves the full stack JavaScript path
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests