Fixed: Broken Release Metadata Fetch due to Lib Update

TheGershon · Aug 4, 2022 · 6ef061f · 6ef061f
1 parent c6b197c
commit 6ef061f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/source/Reloaded.Mod.Launcher/Pages/BaseSubpages/DownloadPackagesPage.xaml b/source/Reloaded.Mod.Launcher/Pages/BaseSubpages/DownloadPackagesPage.xaml
@@ -14,15 +14,14 @@
       Title="{DynamicResource TitleDownloadMods}">
     <Grid x:Name="Contents" DataContext="{Binding Path=ViewModel, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType={x:Type Page}}}">
 
-        <Grid.Resources>
-            <download:CheckForUpdatesAndDependenciesCommand x:Key="CheckForUpdatesAndDependenciesCommand"/>
-        </Grid.Resources>
-
         <Grid.RowDefinitions>
             <RowDefinition Height="Auto"/>
             <RowDefinition Height="*"/>
         </Grid.RowDefinitions>
 
+        <!-- Current Item Overlay -->
+
+
         <!-- Search -->
         <Grid Grid.Row="0" HorizontalAlignment="Stretch" Margin="{DynamicResource CommonItemVerticalMarginSmall}">
             <Grid.ColumnDefinitions>

diff --git a/source/Reloaded.Mod.Loader.Update/Providers/GameBanana/GameBananaPackageProvider.cs b/source/Reloaded.Mod.Loader.Update/Providers/GameBanana/GameBananaPackageProvider.cs
@@ -15,6 +15,8 @@ public class GameBananaPackageProvider : IDownloadablePackageProvider
     /// </summary>
     public int GameId { get; private set; }
 
+    private string _dummyFolderForReleaseVerification = Path.GetTempPath();
+
     /// <summary/>
     public GameBananaPackageProvider(int gameId)
     {
@@ -118,7 +120,7 @@ private static bool CheckIfHasMultipleReloadedFiles(Dictionary<string, GameBanan
         return false;
     }
 
-    private static async Task<bool> TryAddResultsFromReleaseMetadataAsync(GameBananaMod gbApiItem, ConcurrentBag<IDownloadablePackage> results)
+    private async Task<bool> TryAddResultsFromReleaseMetadataAsync(GameBananaMod gbApiItem, ConcurrentBag<IDownloadablePackage> results)
     {
         const string metadataExtension = ".json";
         const int maxFileSize = 512 * 1024; // 512KB. To prevent abuse of large JSON files.
@@ -140,7 +142,7 @@ private static async Task<bool> TryAddResultsFromReleaseMetadataAsync(GameBanana
         return numAddedItems > 0;
     }
 
-    private static async Task<int> TryAddResultFromReleaseMetadataFile(ConcurrentBag<IDownloadablePackage> results, WebClient client, GameBananaModFile file, GameBananaMod item)
+    private async Task<int> TryAddResultFromReleaseMetadataFile(ConcurrentBag<IDownloadablePackage> results, WebClient client, GameBananaModFile file, GameBananaMod item)
     {
         var metadata = await client.DownloadDataTaskAsync(new Uri(file.DownloadUrl!));
         try
@@ -152,7 +154,11 @@ private static async Task<int> TryAddResultFromReleaseMetadataFile(ConcurrentBag
 
             // Get the highest version of release.
             var highestVersion = releaseMetadata.Releases.OrderByDescending(x => new NuGetVersion(x.Version)).First();
-            var newestRelease = releaseMetadata.GetRelease(highestVersion.Version, new ReleaseMetadataVerificationInfo());
+            var newestRelease = releaseMetadata.GetRelease(highestVersion.Version, new ReleaseMetadataVerificationInfo()
+            {
+                FolderPath = _dummyFolderForReleaseVerification
+            });
+
             if (newestRelease == null)
                 return 0;