Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Recursive tree traversal techniques #1865

Merged
merged 16 commits into from
Jan 12, 2022

Conversation

Lazeeez
Copy link
Contributor

@Lazeeez Lazeeez commented Jan 4, 2022

Description of Change

All Tree traversal techniques (inorder, postorder, preorder) with recursive functions.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Added tree traversal implementations with recursive functions.

@Lazeeez
Copy link
Contributor Author

Lazeeez commented Jan 4, 2022

@Panquesito7 can you check the PR now, thanks.

Qannaf
Qannaf previously approved these changes Jan 4, 2022
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jan 4, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the requested changes changes have been requested label Jan 4, 2022
@Lazeeez
Copy link
Contributor Author

Lazeeez commented Jan 4, 2022

@Panquesito7 changes done.

@Lazeeez Lazeeez requested a review from Panquesito7 January 5, 2022 06:27
@Panquesito7
Copy link
Member

@Panquesito7 changes done.

Hey there! Hmm, I don't see any new commits 👀 I think you forgot to push or something, not sure. 😅

@Lazeeez
Copy link
Contributor Author

Lazeeez commented Jan 6, 2022

@Panquesito7 check now, had to manually do all the changes.

Panquesito7
Panquesito7 previously approved these changes Jan 9, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Jan 9, 2022
Copy link
Member

@mishraabhinn mishraabhinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this makes it cleaner to read. If you like this @Lazeeez @Panquesito7 we can change it as suggested thanks.

others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
others/recursive_tree_traversal.cpp Outdated Show resolved Hide resolved
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
Lazeeez and others added 4 commits January 12, 2022 02:37
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
Lazeeez and others added 2 commits January 12, 2022 02:37
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
Co-authored-by: Abhinn Mishra <49574460+mishraabhinn@users.noreply.github.com>
@github-actions github-actions bot force-pushed the recursive_tree_traversal branch 2 times, most recently from 374386f to 409bdfd Compare January 11, 2022 21:08
@Lazeeez
Copy link
Contributor Author

Lazeeez commented Jan 11, 2022

@mishraabhinn changes made, will keep it in mind next time, thanks.

@Lazeeez Lazeeez requested a review from mishraabhinn January 11, 2022 21:11
@Panquesito7 Panquesito7 merged commit 909f7b8 into TheAlgorithms:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants