-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diode Insertion Overhaul #1686
Diode Insertion Overhaul #1686
Conversation
kareefardi
commented
Mar 20, 2023
•
edited
Loading
edited
quit when it should
handle bad encoding :(
Just wanna say, it's an incredible power move to review your own PR and then fix it, absolutely mental |
rename --short-span to --min-distance remove fake_diode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also wondering if adding diodes to I/Os should be a separate step from the heuristic inserter altogether. Since we're not in THAT much of a hurry, might as well do this right?
fix typo in DIODE_ON_PORT
fix default of DIODE_ON_PORTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM- will merge after CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the sky falllll