Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): occasional crash of CFRunloop in looper driver #4164

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix(ios): occasional crash of CFRunloop in looper driver #4164

merged 2 commits into from
Jan 3, 2025

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Jan 3, 2025

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from etkmao as a code owner January 3, 2025 11:04
@github-actions github-actions bot added module: footstone size: xs Denotes a PR that changes 0-9 lines labels Jan 3, 2025
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 3, 2025

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

etkmao
etkmao approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@etkmao etkmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etkmao etkmao enabled auto-merge (squash) January 3, 2025 11:34
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wwwcg
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 3, 2025

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 3, 2025
@hippy-actions hippy-actions bot disabled auto-merge January 3, 2025 11:35
@hippy-actions hippy-actions bot enabled auto-merge (rebase) January 3, 2025 11:35
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 3, 2025
@wwwcg wwwcg disabled auto-merge January 3, 2025 11:47
@wwwcg wwwcg merged commit ee70684 into Tencent:main Jan 3, 2025
24 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etkmao etkmao etkmao approved these changes

Assignees
No one assigned
Labels
module: footstone size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wwwcg @tencent-adm @etkmao @open-hippy