Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dom): fix animation not work for same animation id #4143

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(dom): fix animation not work for same animation id #4143

merged 2 commits into from
Dec 4, 2024

Conversation

zealotchen0
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@zealotchen0 zealotchen0 changed the title Fix/animation same fix(dom): fix animation not work for same animation id Dec 4, 2024
@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Dec 4, 2024
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 4, 2024

Hi, @zealotchen0. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

etkmao
etkmao approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@etkmao etkmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 4, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zealotchen0 zealotchen0 merged commit 6c9e3af into Tencent:main Dec 4, 2024
36 of 39 checks passed
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Dec 4, 2024
@zealotchen0 @wwwcg
fix(dom): fix animation not work for same animation id (Tencent#4143)
f43e4db 
* fix(dom): fix animation not work for same animation id

* feat(dom): add same animation id demo
wwwcg pushed a commit that referenced this pull request Dec 4, 2024
@zealotchen0 @wwwcg
fix(dom): fix animation not work for same animation id (#4143)
e1e6cf3 
* fix(dom): fix animation not work for same animation id

* feat(dom): add same animation id demo
zealotchen0 added a commit to zealotchen0/Hippy that referenced this pull request Dec 13, 2024
@zealotchen0
fix(dom): fix animation not work for same animation id (Tencent#4143)
0496429 
* fix(dom): fix animation not work for same animation id

* feat(dom): add same animation id demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etkmao etkmao etkmao approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese

Assignees
No one assigned
Labels
dom: animation driver: js size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zealotchen0 @tencent-adm @etkmao