Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch Log Groups: Edge Cache Region management #32

Open
petewilcock opened this issue Jun 25, 2021 · 4 comments
Open

Cloudwatch Log Groups: Edge Cache Region management #32

petewilcock opened this issue Jun 25, 2021 · 4 comments
Assignees
Labels
CloudWatch enhancement New feature or request
Milestone

Comments

@petewilcock
Copy link
Contributor

No description provided.

@petewilcock petewilcock added CloudWatch enhancement New feature or request labels Jun 25, 2021
@petewilcock petewilcock added this to the 0.2.0 milestone Jun 25, 2021
@petewilcock petewilcock self-assigned this Jun 25, 2021
@jtatum
Copy link

jtatum commented Jul 5, 2021

One idea is to remove the CreateLogGroup permission from the lambda. That way it won't be able to create unlimited retention log groups in arbitrary regions. Note you'll also want to remove the AWSLambdaBasicExecutionRole - it has permissions to create log groups (and conflicts with the lambda-edge-cloudwatch-logs policy).

@petewilcock
Copy link
Contributor Author

One idea is to remove the CreateLogGroup permission from the lambda.

I'm aware of this trick but I think it's a poor substitute (on AWS' part) for not having better configurability of the automatic log groups used by Lambdas. As the name of the group and the region the groups will be created in is known, this can be anticipated and configured ahead of time - it's just the hell of figuring out a method of doing this that doesn't require the user to pass 17 different providers to the module (I'm not even inflating that number!) to do the thing in each region.

@jtatum
Copy link

jtatum commented Jul 5, 2021

Yeah, exactly. Terraform doesn't exactly make this easy, either. On the balance, it's probably better to have no logs for the redirect service (are they even useful outside of test and dev?) than infinite retention logs, at least by my reckoning.

@petewilcock
Copy link
Contributor Author

It's a fair point. I've seen ever-growing Cloudwatch log groups getting into the 100s of GBs because they were left unconfigured. :( It's a growing cost over time which is the antithesis of this set-up. I'll think about it, worst case it's another configurable flag 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CloudWatch enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants