Skip to content
This repository has been archived by the owner on Mar 19, 2023. It is now read-only.

Commit

Permalink
extract dimensions from fragment_quick_sell.xml keyboard buttons
Browse files Browse the repository at this point in the history
  • Loading branch information
@Tarek-Bohdima
Tarek-Bohdima committed Apr 18, 2022
1 parent 516c231 commit 3d78e8e
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
45 changes: 22 additions & 23 deletions app/src/main/res/layout/fragment_quick_sell.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="24dp"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_one"
app:layout_constraintEnd_toStartOf="@+id/button_2"
app:layout_constraintHorizontal_bias="0.5"
Expand All @@ -30,20 +30,19 @@
android:id="@+id/button_2"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_two"
app:layout_constraintBottom_toBottomOf="@+id/button_1"
app:layout_constraintEnd_toStartOf="@+id/button_3"
app:layout_constraintHorizontal_bias="0.5"
app:layout_constraintStart_toEndOf="@+id/button_1"
app:layout_constraintTop_toTopOf="@+id/button_1"
app:layout_constraintVertical_bias="0.0" />
app:layout_constraintTop_toTopOf="@+id/button_1" />

<Button
android:id="@+id/button_3"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_three"
app:layout_constraintBottom_toBottomOf="@+id/button_2"
app:layout_constraintEnd_toStartOf="@+id/button_c"
Expand All @@ -68,7 +67,7 @@
android:id="@+id/button_4"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_four"
app:layout_constraintEnd_toStartOf="@+id/button_5"
app:layout_constraintHorizontal_bias="0.5"
Expand All @@ -80,7 +79,7 @@
android:id="@+id/button_5"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_five"
app:layout_constraintBottom_toBottomOf="@+id/button_4"
app:layout_constraintEnd_toStartOf="@+id/button_6"
Expand All @@ -92,7 +91,7 @@
android:id="@+id/button_6"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_six"
app:layout_constraintBottom_toBottomOf="@+id/button_5"
app:layout_constraintEnd_toStartOf="@+id/button_del"
Expand All @@ -115,7 +114,7 @@
android:id="@+id/button_7"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_seven"
app:layout_constraintEnd_toStartOf="@+id/button_8"
app:layout_constraintHorizontal_bias="0.5"
Expand All @@ -127,7 +126,7 @@
android:id="@+id/button_8"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_eight"
app:layout_constraintBottom_toBottomOf="@+id/button_7"
app:layout_constraintEnd_toStartOf="@+id/button_9"
Expand All @@ -139,7 +138,7 @@
android:id="@+id/button_9"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_nine"
app:layout_constraintBottom_toBottomOf="@+id/button_8"
app:layout_constraintEnd_toStartOf="@+id/button_keyboard_ok"
Expand All @@ -162,7 +161,7 @@
android:id="@+id/button_0"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_zero"
app:layout_constraintEnd_toStartOf="@+id/button_00"
app:layout_constraintHorizontal_bias="0.5"
Expand All @@ -175,7 +174,7 @@
android:id="@+id/button_00"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginEnd="4dp"
android:layout_marginEnd="@dimen/margin_xsmall"
android:text="@string/text_button_double_zero"
app:layout_constraintBottom_toBottomOf="@+id/button_0"
app:layout_constraintEnd_toStartOf="@+id/button_000"
Expand Down Expand Up @@ -212,7 +211,7 @@
layout="@layout/products_list"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="16dp"
android:layout_marginTop="@dimen/margin_regular"
android:clipToPadding="false"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand All @@ -222,7 +221,7 @@
android:id="@+id/image_selected_product"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="16dp"
android:layout_marginTop="@dimen/margin_regular"
android:contentDescription="@string/selected_product_content_description"
app:layout_constraintStart_toStartOf="@+id/guidelineStart"
app:layout_constraintTop_toBottomOf="@+id/recyclerview_included"
Expand All @@ -233,8 +232,8 @@
android:id="@+id/product_text_group"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="16dp"
android:layout_marginEnd="16dp"
android:layout_marginStart="@dimen/margin_regular"
android:layout_marginEnd="@dimen/margin_regular"
app:constraint_referenced_ids="text_category,textview_product"
app:layout_constraintBottom_toBottomOf="@+id/image_selected_product"
app:layout_constraintEnd_toEndOf="parent"
Expand All @@ -245,8 +244,8 @@
android:id="@+id/text_category"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="16dp"
android:layout_marginBottom="16dp"
android:layout_marginStart="@dimen/margin_regular"
android:layout_marginBottom="@dimen/margin_regular"
android:padding="@dimen/padding_small"
app:layout_constraintBottom_toTopOf="@+id/textview_product"
app:layout_constraintEnd_toEndOf="parent"
Expand All @@ -259,8 +258,8 @@
android:id="@+id/textview_product"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_marginStart="@dimen/margin_regular"
android:layout_marginTop="@dimen/margin_regular"
android:padding="@dimen/padding_small"
app:layout_constraintBottom_toBottomOf="@+id/image_selected_product"
app:layout_constraintEnd_toEndOf="parent"
Expand Down Expand Up @@ -295,8 +294,8 @@
android:id="@+id/textview_input_amount"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="8dp"
android:layout_marginTop="32dp"
android:layout_marginStart="@dimen/margin_small"
android:layout_marginTop="@dimen/margin_large"
android:padding="@dimen/padding_small"
android:text="@string/text_amount_number"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/dimens.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@
<dimen name="spinner_hight">48dp</dimen>
<dimen name="quicksell_cta_width">200dp</dimen>
<dimen name="padding_small">8dp</dimen>
<dimen name="margin_xsmall">4dp</dimen>
</resources>

0 comments on commit 3d78e8e

Please sign in to comment.