Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG/Help] possible bug: result of float conversion is not stored #1489

Open
1 task done
jben-hun opened this issue Jul 30, 2024 · 0 comments
Open
1 task done

[BUG/Help] possible bug: result of float conversion is not stored #1489

jben-hun opened this issue Jul 30, 2024 · 0 comments

Comments

@jben-hun
Copy link

jben-hun commented Jul 30, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

.float().cuda() is called, which is equivalent to: .to(torch.float32).cuda(), but the result is not stored, so the line has no effect apart from possibly unnecessary workload
line:

ChatGLM-6B/ptuning/main.py

Line 132 in 401bf3a

model.transformer.prefix_encoder.float()

Expected Behavior

No response

Steps To Reproduce

does not apply

Environment

any

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jben-hun