Fix activeDeadline would be triggered even after the job is completed. (

kubeflow#24) Signed-off-by: Syulin7 <735122171@qq.com>
Syulin7 · May 29, 2024 · b457b4a · b457b4a
1 parent cae29f8
commit b457b4a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/controller.v1/tensorflow/controller.go b/pkg/controller.v1/tensorflow/controller.go
@@ -592,7 +592,7 @@ func (tc *TFController) pastBackoffLimit(tfjob *tfv1.TFJob, pods []*v1.Pod) (boo
 
 // pastActiveDeadline checks if job has ActiveDeadlineSeconds field set and if it is exceeded.
 func (tc *TFController) pastActiveDeadline(tfjob *tfv1.TFJob) bool {
-	if tfjob.Spec.ActiveDeadlineSeconds == nil || tfjob.Status.StartTime == nil {
+	if tfjob.Spec.ActiveDeadlineSeconds == nil || tfjob.Status.StartTime == nil || tfjob.Status.CompletionTime != nil {
 		return false
 	}
 	now := metav1.Now()