-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a BC layer for files in "app/config/" referenced by PluginSkeleton #9672
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Provide a BC layer for files in "app/config/" referenced by Sylius di…
…stributions
- Loading branch information
commit 96bbbc9b6af23fcb6f6afd7a0a300efee79d5863
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Sylius package. | ||
* | ||
* (c) Paweł Jędrzejewski | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
/** | ||
* @internal | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
@trigger_error('Importing files from Sylius/Sylius\'s "app/config" directory is deprecated since Sylius 1.3.', \E_USER_DEPRECATED); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Sylius package. | ||
* | ||
* (c) Paweł Jędrzejewski | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
/** | ||
* @internal | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
use Symfony\Component\Routing\RouteCollection; | ||
|
||
@trigger_error('Importing files from Sylius/Sylius\'s "app/config" directory is deprecated since Sylius 1.3.', \E_USER_DEPRECATED); | ||
|
||
return new RouteCollection(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# This file is referenced in PluginSkeleton v1.0.0 - v1.2.x | ||
# It is deprecated since Sylius 1.3 and will be removed in Sylius 2.0 | ||
|
||
_routing_deprecation: | ||
resource: '_routing_deprecation.php' # Triggers a deprecation error | ||
|
||
_routing_directory: | ||
resource: '../../config/{routes}/*.{php,xml,yaml,yml}' | ||
type: glob | ||
|
||
_routing_environment_directory: | ||
resource: '../../config/{routes}/%kernel.environment%/**/*.{php,xml,yaml,yml}' | ||
type: glob | ||
|
||
_routing_file: | ||
resource: '../../config/{routes}.{php,xml,yaml,yml}' | ||
type: glob |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# This file is referenced in PluginSkeleton v1.0.0 - v1.2.x | ||
# It is deprecated since Sylius 1.3 and will be removed in Sylius 2.0 | ||
|
||
_routing: | ||
resource: 'routing.yml' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# This file is referenced in PluginSkeleton v1.0.0 - v1.2.x | ||
# It is deprecated since Sylius 1.3 and will be removed in Sylius 2.0 | ||
|
||
# Imported new security.yaml makes use of `APP_SECRET` environmental variable | ||
# We fallback it to `secret` parameter if that env variable is not found to provide a BC layer | ||
parameters: | ||
env(APP_SECRET): '%secret%' | ||
|
||
imports: | ||
- { resource: '_container_deprecation.php' } # Triggers a deprecation error | ||
- { resource: '../../config/packages/security.yaml' } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating YAML files is kinda weird 🎉