Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a BC layer for files in "app/config/" referenced by PluginSkeleton #9672

Merged
merged 1 commit into from
Aug 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Provide a BC layer for files in "app/config/" referenced by Sylius di…
…stributions
  • Loading branch information
pamil committed Aug 24, 2018
commit 96bbbc9b6af23fcb6f6afd7a0a300efee79d5863
4 changes: 4 additions & 0 deletions app/AppKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
* file that was distributed with this source code.
*/

/**
* @internal
*/

declare(strict_types=1);

@trigger_error('The "AppKernel" class located at "app/AppKernel.php" is deprecated since Sylius 1.3. Use "Kernel" class located at "src/Kernel.php" instead.', E_USER_DEPRECATED);
Expand Down
4 changes: 4 additions & 0 deletions app/TestAppKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
* file that was distributed with this source code.
*/

/**
* @internal
*/

declare(strict_types=1);

@trigger_error('The "TestAppKernel" class located at "app/TestAppKernel.php" is deprecated since Sylius 1.3. Use "Kernel" class located at "src/Kernel.php" instead.', E_USER_DEPRECATED);
Expand Down
18 changes: 18 additions & 0 deletions app/config/_container_deprecation.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

/*
* This file is part of the Sylius package.
*
* (c) Paweł Jędrzejewski
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/**
* @internal
*/

declare(strict_types=1);

@trigger_error('Importing files from Sylius/Sylius\'s "app/config" directory is deprecated since Sylius 1.3.', \E_USER_DEPRECATED);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating YAML files is kinda weird 🎉

22 changes: 22 additions & 0 deletions app/config/_routing_deprecation.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

/*
* This file is part of the Sylius package.
*
* (c) Paweł Jędrzejewski
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/**
* @internal
*/

declare(strict_types=1);

use Symfony\Component\Routing\RouteCollection;

@trigger_error('Importing files from Sylius/Sylius\'s "app/config" directory is deprecated since Sylius 1.3.', \E_USER_DEPRECATED);

return new RouteCollection();
17 changes: 17 additions & 0 deletions app/config/routing.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# This file is referenced in PluginSkeleton v1.0.0 - v1.2.x
# It is deprecated since Sylius 1.3 and will be removed in Sylius 2.0

_routing_deprecation:
resource: '_routing_deprecation.php' # Triggers a deprecation error

_routing_directory:
resource: '../../config/{routes}/*.{php,xml,yaml,yml}'
type: glob

_routing_environment_directory:
resource: '../../config/{routes}/%kernel.environment%/**/*.{php,xml,yaml,yml}'
type: glob

_routing_file:
resource: '../../config/{routes}.{php,xml,yaml,yml}'
type: glob
5 changes: 5 additions & 0 deletions app/config/routing_dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# This file is referenced in PluginSkeleton v1.0.0 - v1.2.x
# It is deprecated since Sylius 1.3 and will be removed in Sylius 2.0

_routing:
resource: 'routing.yml'
11 changes: 11 additions & 0 deletions app/config/security.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This file is referenced in PluginSkeleton v1.0.0 - v1.2.x
# It is deprecated since Sylius 1.3 and will be removed in Sylius 2.0

# Imported new security.yaml makes use of `APP_SECRET` environmental variable
# We fallback it to `secret` parameter if that env variable is not found to provide a BC layer
parameters:
env(APP_SECRET): '%secret%'

imports:
- { resource: '_container_deprecation.php' } # Triggers a deprecation error
- { resource: '../../config/packages/security.yaml' }