Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan 0.10 upgrade & road to level 2 checks #9540

Merged
merged 7 commits into from
Jul 3, 2018
Merged

PHPStan 0.10 upgrade & road to level 2 checks #9540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b653bdf
Install PHPStan 0.10 & Webmozart/Assert extension
pamil Jul 1, 2018
66deb99
Fix constraint class related ambiguities in validators
pamil Jul 1, 2018
59fc6f2
Install Symfony extension for PHPStan
pamil Jul 1, 2018
1e91d51
Install Doctrine extension for PHPStan
pamil Jul 1, 2018
59b8ea2
Random PHPStan fixed (level 2)
pamil Jul 1, 2018
b2c3047
Apply coding standard fixes
pamil Jul 1, 2018
e0dff4a
Make tests passing again
pamil Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make tests passing again
  • Loading branch information
@pamil
pamil committed Jul 2, 2018
commit e0dff4af720165ef58528d077c6e9ec141cfb43d
4 changes: 2 additions & 2 deletions features/checkout/placing_an_order_with_different_scopes_for_shipping_and_taxes.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Feature: Placing an order with different scopes for shipping and taxes
And I proceed with "Free" shipping method and "Offline" payment
Then I should be on the checkout summary step
And my tax total should be "$1.60"
And my order total should be "$21.6"
And my order total should be "$21.60"

@ui @javascript
Scenario: Placing an order with in the same tax and shipping zone
Expand All @@ -44,7 +44,7 @@ Feature: Placing an order with different scopes for shipping and taxes
And I proceed with "Free" shipping method and "Offline" payment
Then I should be on the checkout summary step
And my tax total should be "$1.60"
And my order total should be "$21.6"
And my order total should be "$21.60"

@ui @javascript
Scenario: Placing an order within shipping zone
Expand Down
2 changes: 1 addition & 1 deletion src/Sylius/Behat/Page/Shop/Checkout/CompletePage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ private function getCountryName($countryCode)
*/
private function getPriceFromString($price): int
{
return (int) round((int) str_replace(['€', '£', '$'], '', $price) * 100, 2);
return (int) round((float) str_replace(['€', '£', '$'], '', $price) * 100, 2);
}

/**
Expand Down