Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Travis] Allow failures for PHP 7.2 builds #8868

Merged
merged 2 commits into from
Oct 17, 2017
Merged

[Travis] Allow failures for PHP 7.2 builds #8868

merged 2 commits into from
Oct 17, 2017

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 17, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #8771
License MIT

@pamil pamil added Critical Issues and PRs, which are critical and should be fixed ASAP. Maintenance CI configurations, READMEs, releases, etc. labels Oct 17, 2017
@pamil pamil added this to the 1.0 milestone Oct 17, 2017
@pamil pamil self-assigned this Oct 17, 2017
@stefandoorn
Copy link
Contributor

Why would we allow failures in here? I would say that for 'nightly' builds it's ok to fail, but for the next upcoming PHP release it sounds not really good for me.

@pamil
Copy link
Contributor Author

pamil commented Oct 17, 2017

The build is currently failing on https://travis-ci.org/Sylius/Sylius/builds/289046134, it wasn't covered by Travis' in your PR because of #8851 which gets reverted in #8867.

@pamil pamil mentioned this pull request Oct 17, 2017
Closed
@pamil pamil closed this Oct 17, 2017
@pamil pamil reopened this Oct 17, 2017
@pamil pamil force-pushed the 1.0-allow-failures-7.2 branch from 0b5ef96 to 1136af9 Compare October 17, 2017 15:26
@pamil pamil merged commit af13f2c into Sylius:1.0 Oct 17, 2017
@pamil pamil deleted the 1.0-allow-failures-7.2 branch October 17, 2017 16:03
@pamil pamil mentioned this pull request Oct 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees

@pamil pamil

Labels
Critical Issues and PRs, which are critical and should be fixed ASAP. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pamil @stefandoorn @lchrusciel