Product reviews API #8772
[Product Reviews API] - minor changes
- Loading branch information
commit 4aa26f9510a1a27800f768bb831a31ca0f2a0cdf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,10 +50,10 @@ public function findAcceptedByProductSlugAndChannel(string $slug, string $locale | |
| public function createQueryBuilderByProductCode(string $locale, string $productCode): QueryBuilder; | ||
|
There was a problem hiding this comment. Adding methods to an interface is a BC break. There was a problem hiding this comment. @pamil, in this case how can proceed next? Should we put the methods only into the ProductReviewRepository? There was a problem hiding this comment. According to our proposed BC promise (#8901), it isn't a BC break 🎉 |
||
|
|
||
| /** | ||
| * @param mixed $id | ||
| * @param string $productCode | ||
|
|
||
| * | ||
| * @return ReviewInterface|null | ||
| */ | ||
| public function findOneByIdAndProductCode($id, string $productCode): ?ReviewInterface; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,92 +1,92 @@ | ||
| { | ||
| "id": @integer@, | ||
| "title": "mug_review_best", | ||
| "rating": 4, | ||
| "comment": "mug_review_best_comment", | ||
| "author": { | ||
| "id": @integer@, | ||
| "email": "example.queen@example.com", | ||
| "emailCanonical": "example.queen@example.com", | ||
| "firstName": "Example", | ||
| "lastName": "Queen", | ||
| "gender": "u", | ||
| "_links": { | ||
| "self": { | ||
| "href": @string@ | ||
| } | ||
| } | ||
| }, | ||
| "status": "accepted", | ||
| "reviewSubject": { | ||
| "id": @integer@, | ||
| "code": "MUG_REVIEW_BEST", | ||
| "attributes": [], | ||
| "options": [], | ||
| "associations": [], | ||
| "translations": { | ||
| "en": { | ||
| "locale": "en" | ||
| } | ||
| }, | ||
| "productTaxons": [], | ||
| "channels": [], | ||
| "reviews": { | ||
| "1": { | ||
| "id": @integer@, | ||
| "title": "mug_review_good", | ||
| "rating": 3, | ||
| "comment": "mug_review_good_comment", | ||
| "author": { | ||
| "id": @integer@, | ||
| "email": "example.queen@example.com", | ||
| "emailCanonical": "example.queen@example.com", | ||
| "firstName": "Example", | ||
| "lastName": "Queen", | ||
| "gender": "u", | ||
| "_links": { | ||
| "self": { | ||
| "href": @string@ | ||
| } | ||
| } | ||
| }, | ||
| "status": "rejected", | ||
| "createdAt": @string@, | ||
| "updatedAt": @string@ | ||
| }, | ||
| "2": { | ||
| "id": @integer@, | ||
| "title": "mug_review_bad", | ||
| "rating": 1, | ||
| "comment": "mug_review_bad_comment", | ||
| "author": { | ||
| "id": @integer@, | ||
| "email": "example.queen@example.com", | ||
| "emailCanonical": "example.queen@example.com", | ||
| "firstName": "Example", | ||
| "lastName": "Queen", | ||
| "gender": "u", | ||
| "_links": { | ||
| "self": { | ||
| "href": @string@ | ||
| } | ||
| } | ||
| }, | ||
| "status": "accepted", | ||
| "createdAt": @string@, | ||
| "updatedAt": @string@ | ||
| } | ||
| }, | ||
| "averageRating": 2.5, | ||
| "images": [], | ||
| "_links": { | ||
| "self": { | ||
| "href": "/api/v1/products/MUG_REVIEW_BEST" | ||
| }, | ||
| "variants": { | ||
| "href": "/api/v1/products/MUG_REVIEW_BEST/variants/" | ||
| } | ||
| } | ||
| }, | ||
| "createdAt": @string@, | ||
| "updatedAt": @string@ | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "code":400, | ||
| "message":"" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,4 +109,4 @@ | |
| }, | ||
| "createdAt": @string@, | ||
| "updatedAt": @string@ | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,4 +36,4 @@ | |
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,4 @@ | |
| "_embedded": { | ||
| "items": [] | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that product_review should be before product_variant to keep alphabetical order