Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison of order items #17070

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix comparison of order items #17070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix comparison of order items 
Fix comparison of order items when one of them is Doctrine proxy object
  • Loading branch information
@jaroslavtyc
jaroslavtyc authored Oct 1, 2024
commit 9b0c5cf49bd45adce337fefdc8bc4ce5e295e4a1
2 changes: 1 addition & 1 deletion src/Sylius/Component/Core/Model/OrderItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function setVariantName(?string $variantName): void

public function equals(BaseOrderItemInterface $orderItem): bool
{
return parent::equals($orderItem) || ($orderItem instanceof static && $orderItem->getVariant() === $this->variant);
return parent::equals($orderItem) || ($orderItem instanceof self && $orderItem->getVariant() === $this->variant);
}

/**
Expand Down
Loading