Migrating the shop grid configuration to php #15419

mamazu · 2023-10-08T17:14:54Z

Paritally copying over some of the grids from #14449

Q	A
Branch?	1.13
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	partially #14449
License	MIT

To be able to get this merged quicker this MR contains the shop grid bundle changes only for the shop.

github-actions · 2023-10-08T17:27:09Z

Bunnyshell Preview Environment deployed

It will be automatically stopped in 4 hours.

Use the command /bns:start to start it if it's stopped.

Component	Endpoints
mailhog	https://mailhog-op7xze.bunnyenv.com/
php	https://store-op7xze.bunnyenv.com/

Available commands:

/bns:stop to stop the environment
/bns:deploy to redeploy the environment
/bns:delete to remove the environment

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

mamazu · 2023-10-09T17:30:09Z

@Florian-Merle I think this could be a problem with the expression language not working correctly?

diimpp · 2023-10-09T22:44:02Z

Hi, as #14449 (comment) Loic mentioned, this most likely should target 2.0. For example new workflow SM are specifically done in yaml instead of php for 1.13.

mamazu · 2023-10-10T08:36:24Z

Rebased to 2.0. Sadly I still don't have a way to test the changes as I don't have a local development environment for 1.13.

mamazu · 2023-10-17T07:13:23Z

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

+        // @see Sylius\Bundle\ResourceBundle\ExpressionLanguage\NotNullExpressionFunctionProvider
+        $taxon = $this->taxonRepository->findOneBySlug(
+                    $this->resquest->attributes->get('slug'),
+                    $localeCode,
+        );
+        if ($taxon === null)  {
+            throw new NotFoundHttpException('Requested page is invalid');
+        }


We might want to move that to a helper or somewhere?

@diimpp Any ideas or thoughts on this one? I guess it would make sense to make a class or a trait that could emulate what we had in the expression parser.

src/Sylius/Bundle/ShopBundle/Resources/views/Account/Order/Grid/Action/pay.html.twig

mamazu · 2023-10-17T14:51:51Z

@diimpp Can someone with some behat expertise have a look, I don't understand what the problem is. The button should be there.

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

src/Sylius/Bundle/ShopBundle/Grid/Account/OrderGrid.php

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

src/Sylius/Bundle/ShopBundle/Resources/views/Account/Order/Grid/Action/pay.html.twig

src/Sylius/Bundle/ShopBundle/Grid/Account/OrderGrid.php

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

src/Sylius/Bundle/ShopBundle/Grid/Account/OrderGrid.php

src/Sylius/Bundle/ShopBundle/Resources/config/services/grid.xml

src/Sylius/Bundle/ShopBundle/Grid/Account/OrderGrid.php

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

src/Sylius/Bundle/ShopBundle/Resources/config/services/grid.xml

mamazu · 2023-10-18T10:41:43Z

I am using the same actions as before now (they are the same, but have different templates to make overriding them easier.

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

src/Sylius/Bundle/ShopBundle/Grid/Account/OrderGrid.php

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php

loic425 · 2023-10-21T08:12:50Z

Please keep the yaml configuration, the configuration are not merged. I will make a new provider for a bc layer to migrate grid per grid for end users. I'll make it probably next week.

loic425

See my other comment

mamazu · 2023-10-21T17:23:54Z

I don't yet understand why but I can revert the grid configuration.

loic425 · 2023-10-22T11:47:42Z

I don't yet understand why but I can revert the grid configuration.

https://github.com/Sylius/SyliusGridBundle/blob/1.13/src/Component/Provider/ChainProvider.php

there are two providers to retrieve the grid configuration. When a developer has customized the sylius grid with yaml it will not work cause the service grid provider configuration will be retrieved first.

I have an idea for a new provider to make a bc layer

loic425 · 2024-01-02T13:07:56Z

I think we can base this one to 1.13. But let's wait for other core team opinions.

diimpp · 2024-01-06T17:14:33Z

I think we can base this one to 1.13. But let's wait for other core team opinions.

@loic425 I think we're keeping yaml at 1.13 and php configs are for 2.0. Same was done for SF workflows.

mamazu · 2024-03-09T21:44:07Z

So what's the status on this one? Can loics PR be merged and mine too. Because there are still the admin grids that need to be migrated for 2.0

mamazu · 2024-09-07T10:12:46Z

Poking this and #15491 again. It would make finding the grid configuration easier as well. Just search for OrderGrid and you don't have to go through the yaml files or the debugger to find it.

Paritally copying over some of the grids from Sylius#14449

Co-authored-by: Dmitri Perunov <diimpp@gmail.com>

mamazu requested a review from a team as a code owner October 8, 2023 17:14

probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Oct 8, 2023

mamazu force-pushed the php_grids_for_shop_bundle branch 2 times, most recently from 1cc0abe to cc8c992 Compare October 8, 2023 17:23

mamazu commented Oct 8, 2023

View reviewed changes

src/Sylius/Bundle/ShopBundle/Grid/ProductGrid.php Outdated Show resolved Hide resolved

mamazu force-pushed the php_grids_for_shop_bundle branch 2 times, most recently from 2f7ecec to 43e4c2c Compare October 8, 2023 18:40

mamazu force-pushed the php_grids_for_shop_bundle branch from 43e4c2c to 670065d Compare October 10, 2023 08:35

probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Oct 10, 2023

mamazu changed the base branch from 1.13 to 2.0 October 10, 2023 08:35

mamazu force-pushed the php_grids_for_shop_bundle branch 4 times, most recently from a7cff61 to 3e7c4aa Compare October 17, 2023 07:12

mamazu commented Oct 17, 2023

View reviewed changes

mamazu changed the title ~~Applying the shop grids~~ Migrating the shop grid configuration to php Oct 17, 2023

mamazu commented Oct 17, 2023

View reviewed changes

src/Sylius/Bundle/ShopBundle/Resources/views/Account/Order/Grid/Action/pay.html.twig Outdated Show resolved Hide resolved

NoResponseMate reviewed Oct 17, 2023

View reviewed changes

diimpp reviewed Oct 17, 2023

View reviewed changes

mamazu force-pushed the php_grids_for_shop_bundle branch from 16581d0 to f4f1f77 Compare October 19, 2023 15:24

diimpp reviewed Oct 20, 2023

View reviewed changes

mamazu force-pushed the php_grids_for_shop_bundle branch from 25e9f35 to c4a2292 Compare October 20, 2023 17:08

diimpp previously approved these changes Oct 20, 2023

View reviewed changes

loic425 requested changes Oct 21, 2023

View reviewed changes

mamazu dismissed diimpp’s stale review via f7297ff October 21, 2023 17:25

loic425 mentioned this pull request Nov 2, 2023

Configurable grid provider #15491

Open

4 tasks

GSadee requested a review from a team as a code owner July 9, 2024 09:58

NoResponseMate previously approved these changes Sep 16, 2024

View reviewed changes

mamazu and others added 6 commits September 27, 2024 14:20

Applying the shop grids

dfaf4af

Paritally copying over some of the grids from Sylius#14449

Fixing the errors?

97d8268

Adding dirty fix for test

2d73ce1

Fixing errors and adding label back

5a5240b

Apply suggestions from code review

e1258a6

Co-authored-by: Dmitri Perunov <diimpp@gmail.com>

Using the right actions

cb9a90c

mamazu dismissed NoResponseMate’s stale review via cb9a90c September 27, 2024 12:20

mamazu force-pushed the php_grids_for_shop_bundle branch from f7297ff to cb9a90c Compare September 27, 2024 12:20

Removing custom template

c433a7d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrating the shop grid configuration to php #15419

Migrating the shop grid configuration to php #15419

mamazu commented Oct 8, 2023

github-actions bot commented Oct 8, 2023 •

edited

Loading

mamazu commented Oct 9, 2023

diimpp commented Oct 9, 2023

mamazu commented Oct 10, 2023

mamazu Oct 17, 2023

mamazu Oct 19, 2023

mamazu commented Oct 17, 2023

mamazu commented Oct 18, 2023

loic425 commented Oct 21, 2023 •

edited

Loading

loic425 left a comment

mamazu commented Oct 21, 2023

loic425 commented Oct 22, 2023

loic425 commented Jan 2, 2024

diimpp commented Jan 6, 2024 •

edited

Loading

mamazu commented Mar 9, 2024

mamazu commented Sep 7, 2024

Migrating the shop grid configuration to php #15419

Are you sure you want to change the base?

Migrating the shop grid configuration to php #15419

Conversation

mamazu commented Oct 8, 2023

github-actions bot commented Oct 8, 2023 • edited Loading

Bunnyshell Preview Environment deployed

mamazu commented Oct 9, 2023

diimpp commented Oct 9, 2023

mamazu commented Oct 10, 2023

mamazu Oct 17, 2023

Choose a reason for hiding this comment

mamazu Oct 19, 2023

Choose a reason for hiding this comment

mamazu commented Oct 17, 2023

mamazu commented Oct 18, 2023

loic425 commented Oct 21, 2023 • edited Loading

loic425 left a comment

Choose a reason for hiding this comment

mamazu commented Oct 21, 2023

loic425 commented Oct 22, 2023

loic425 commented Jan 2, 2024

diimpp commented Jan 6, 2024 • edited Loading

mamazu commented Mar 9, 2024

mamazu commented Sep 7, 2024

github-actions bot commented Oct 8, 2023 •

edited

Loading

loic425 commented Oct 21, 2023 •

edited

Loading

diimpp commented Jan 6, 2024 •

edited

Loading