Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR][API] Update ADR for providing locales after changing the approach #13772

Merged
merged 2 commits into from
Mar 18, 2022
Merged

[ADR][API] Update ADR for providing locales after changing the approach #13772

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e82e09
[ADR][API] Update ADR for providing locales after changing the approach
GSadee Mar 15, 2022
ff3d798
[ADR][API] Reject the old one and add the new ADR for providing local…
GSadee Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions adr/2021_07_05_api_providing_locales_available_in_active_channel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Using data provider for getting available locales in active channel for shop user
# Using Doctrine Collection extension for getting available locales in active channel for shop user

* Status: proposed
* Date: 2021-07-05
* Status: accepted
* Propose date: 2021-07-05
* Update date: 2022-03-15

## Context and Problem Statement
Customer should have access only to locales available in their channel
Expand All @@ -16,11 +17,11 @@ Customer should have access only to locales available in their channel

### Using Data Provider

* Good, because we already have this approach for older resources
* Good, because it is easy to implement
* Bad, because using data providers omits extra Doctrine extensions like pagination

## Decision Outcome

Chosen option: Using Data Provider
Shops shouldn't have many locales for each channel, so lack of a pagination is smaller problem than creating overcomplicated query in Doctrine Collection extension
Chosen option: **"Using Doctrine Collection extension"**

This option is consistent with current approach and does not omit Doctrine extensions like pagination.