Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR][API] Update ADR for providing locales after changing the approach #13772

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 15, 2022

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets #12766 and #13333
License MIT

@GSadee GSadee added DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc. labels Mar 15, 2022
@GSadee GSadee requested a review from a team as a code owner March 15, 2022 11:16
@Ferror
Copy link
Contributor

Ferror commented Mar 15, 2022

I don't think we should update the ADRs when we change our decision, especially after a year. In that case, I think we should create another ADR with relation to the first one that explains why the previous approach appeared to be wrong.

The decision was made, people died, this cannot be undone :)

@GSadee
Copy link
Member Author

GSadee commented Mar 15, 2022

I don't think we should update the ADRs when we change our decision, especially after a year. In that case, I think we should create another ADR with relation to the first one that explains why the previous approach appeared to be wrong.

The decision was made, people died, this cannot be undone :)

I wonder about doing it in this way, but I wanted to simplify our ADRs, especially that the changed ADR was in proposed state. However, I agree with your arguments and I've added the new ADR with reference to the old one.

@GSadee GSadee force-pushed the change-adr-for-providing-locales branch from 6d1cc2d to ff3d798 Compare March 15, 2022 13:44
@lchrusciel
Copy link
Member

as a contr-argument for changing ADRs with time - we have git in place. Therefore, we could replace them and base our current decisions only on existing ADRs at the moment. Of course, there is one more case - when we are transitioning from one approach to another, while two ADRs may exist: legacy and new one

@AdamKasp AdamKasp merged commit ee9c314 into Sylius:1.11 Mar 18, 2022
@AdamKasp
Copy link
Contributor

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the change-adr-for-providing-locales branch March 18, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants