-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] Replace dbal conflict with explicit requirement #13252
Conversation
lchrusciel
commented
Oct 27, 2021
Q | A |
---|---|
Branch? | 1.9 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | mentioned in #13215 (review) |
License | MIT |
Thank you, Łukasz! 🥇 |
IMHO that conflict & explain was way more useful than just locking to explicit version, cause with explain, anyone who will struggle to update to v3 will be able to see related problem & issue instead of looking for everything on his/her own... |
Hey @stloyd, I can totally understand you. On the contrary, we know, that 2.* is the version supported, but 3.* is not due to the semver. We are basing our build on this explicit version atm. |
I would say:
So I would suggest:
|
…lchrusciel) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #13252 (comment) | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- cc66b79 [Maintenance] Add note about doctrine/dbal requirement