[API] Initial checkout implementation #11670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
Jul 21, 2020
•
lchrusciel
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | Based on #11666 |
| License | MIT |
lchrusciel
added
Feature
Tomanhez
reviewed
Jul 22, 2020
| /** | ||
| * @When I proceed with :shippingMethod shipping method | ||
| */ | ||
| public function iHaveProceededSelectingShippingMethod(ShippingMethodInterface $shippingMethod): void |
There was a problem hiding this comment.
Suggested change
| public function iHaveProceededSelectingShippingMethod(ShippingMethodInterface $shippingMethod): void | |
| public function iProceededWithShippingMethod(ShippingMethodInterface $shippingMethod): void |
| } | ||
|
|
||
| public function __invoke(AddressOrder $addressOrder): OrderInterface | ||
| { |
There was a problem hiding this comment.
$addressOrder->orderTokenValue is used in three places, it should be assigned to new variable
| $paymentMethod = $this->paymentMethodRepository->findOneBy(['code' => $choosePaymentMethod->paymentMethod]); | ||
|
|
||
| Assert::notNull($paymentMethod, 'Payment method has not been found'); | ||
| Assert::true(isset($cart->getPayments()[$choosePaymentMethod->paymentIdentifier]), 'Can not find payment with given identifier.'); |
There was a problem hiding this comment.
$choosePaymentMethod->paymentIdentifier should be assigned to new variable
|
|
||
| Assert::notNull($shippingMethod, 'Shipping method has not been found'); | ||
| Assert::true( | ||
| isset($cart->getShipments()[$chooseShippingMethod->shipmentIdentifier]), |
There was a problem hiding this comment.
$chooseShippingMethod->shipmentIdentifier the same like above comment
| public function __invoke(CompleteOrder $completeOrder): OrderInterface | ||
| { | ||
| /** @var OrderInterface $cart */ | ||
| $cart = $this->orderRepository->findOneBy(['tokenValue' => $completeOrder->orderTokenValue]); |
There was a problem hiding this comment.
$completeOrder->orderTokenValue and here
Comment on lines
+40
to
+45
| OrderRepositoryInterface $orderRepository, | ||
| OrderInterface $order, | ||
| PaymentMethodRepositoryInterface $paymentMethodRepository, | ||
| PaymentMethodInterface $paymentMethod, | ||
| PaymentInterface $payment, | ||
| FactoryInterface $stateMachineFactory, |
There was a problem hiding this comment.
Wrong order, first three arguments should be in order like let function
Comment on lines
+82
to
+87
| OrderRepositoryInterface $orderRepository, | ||
| OrderInterface $order, | ||
| PaymentMethodRepositoryInterface $paymentMethodRepository, | ||
| PaymentInterface $payment, | ||
| FactoryInterface $stateMachineFactory, | ||
| StateMachineInterface $stateMachine |
There was a problem hiding this comment.
Like comment above, here and in every places in this file
Comment on lines
+42
to
+49
| OrderRepositoryInterface $orderRepository, | ||
| OrderInterface $order, | ||
| ShippingMethodRepositoryInterface $shippingMethodRepository, | ||
| ShippingMethodInterface $shippingMethod, | ||
| ShipmentInterface $shipment, | ||
| ShippingMethodEligibilityCheckerInterface $eligibilityChecker, | ||
| FactoryInterface $stateMachineFactory, | ||
| StateMachineInterface $stateMachine |
There was a problem hiding this comment.
Similar like comment above
Comment on lines
+66
to
+69
| FactoryInterface $stateMachineFactory, | ||
| OrderInterface $order, | ||
| OrderRepositoryInterface $orderRepository, | ||
| StateMachineInterface $stateMachine |
Tomanhez
reviewed
Jul 22, 2020
| use Symfony\Component\BrowserKit\AbstractBrowser; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\VarDumper\VarDumper; |
There was a problem hiding this comment.
Suggested change
| use Symfony\Component\VarDumper\VarDumper; | |
| use Symfony\Component\VarDumper\VarDumper; |
not needed
|
Closing in favour of #11675 |
GSadee
added a commit
that referenced
this pull request
Jul 23, 2020
…iel, Tomanhez) This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | License | MIT This pr is based on #11670 <!-- - Bug fixes must be submitted against the 1.7 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 6456377 [API] Initial checkout implementation e0857fc Add fixes for tests
lchrusciel
pushed a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Sep 4, 2020
…iel, Tomanhez) This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | License | MIT This pr is based on Sylius/Sylius#11670 <!-- - Bug fixes must be submitted against the 1.7 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 64563778e6d65948afab089aa1613a4614d88130 [API] Initial checkout implementation e0857fc5a3291ffd4e4d5337c471fe717d903bfa Add fixes for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.