[Behat] Add info type to notification checker

Sylius · lchrusciel · May 13, 2019 · May 8, 2019 · May 8, 2019 · May 9, 2019
commit fd1d220a2cb541d29d3d9316d55e7ab9bea7e377
diff --git a/src/Sylius/Behat/NotificationType.php b/src/Sylius/Behat/NotificationType.php
@@ -21,44 +21,32 @@ final class NotificationType
     /** @var array */
     private static $types = [];
 
-    /**
-     * @param string $value
-     */
-    private function __construct($value)
+    private function __construct(string $value)
     {
         $this->value = $value;
     }
 
-    /**
-     * @return string
-     */
-    public function __toString()
+    public function __toString(): string
     {
         return $this->value;
     }
 
-    /**
-     * @return NotificationType
-     */
-    public static function failure()
+    public static function failure(): NotificationType
     {
         return static::getTyped('failure');
     }
 
-    /**
-     * @return NotificationType
-     */
-    public static function success()
+    public static function success(): NotificationType
     {
         return static::getTyped('success');
     }
 
-    /**
-     * @param string $type
-     *
-     * @return NotificationType
-     */
-    private static function getTyped($type)
+    public static function info(): NotificationType
+    {
+        return static::getTyped('info');
+    }
+
+    private static function getTyped(string $type): NotificationType
     {
         if (!isset(static::$types[$type])) {
             static::$types[$type] = new self($type);

diff --git a/src/Sylius/Behat/Service/NotificationChecker.php b/src/Sylius/Behat/Service/NotificationChecker.php
@@ -35,12 +35,21 @@ public function checkNotification(string $message, NotificationType $type): void
         foreach ($this->notificationAccessor->getMessageElements() as $messageElement) {
             if (
                 false !== strpos($messageElement->getText(), $message) &&
-                $messageElement->hasClass($type->__toString() === 'success' ? 'positive' : 'negative')
+                $messageElement->hasClass($this->resolveClass($type))
             ) {
                 return;
             }
         }
 
         throw new NotificationExpectationMismatchException($type, $message);
     }
+
+    private function resolveClass(NotificationType $type): string
+    {
+        if ($type->__toString() === 'info') {
+            return 'info';
+        }
+
+        return $type->__toString() === 'success' ? 'positive' : 'negative';
+    }
 }